Skip to content

Conversation

@blauerPCL
Copy link
Contributor

@blauerPCL blauerPCL commented Jun 26, 2025

Summary

Initial upload of AL Test Tool tests for the Dynamics SL Migration. This include tests for Accounting Periods, Customers, and Vendors.

Work Item(s)

Fixes # AB#565985
AB#567569
AB#567568
AB#574415

@blauerPCL blauerPCL requested a review from a team as a code owner June 26, 2025 14:52
@blauerPCL blauerPCL requested a review from aholstrup1 June 26, 2025 14:52
@github-actions
Copy link
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

1 similar comment
@github-actions
Copy link
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@blauerPCL
Copy link
Contributor Author

@nikolakukrika Here is the PR for the AL Test Tool tests for the SL Migration

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jul 1, 2025
nikolakukrika
nikolakukrika previously approved these changes Jul 22, 2025
else
CustomerBlocked := true;

if not CustomerDataMigrationFacade.CreateCustomerIfNeeded(SLCustomer.CustId, CopyStr(SLHelperFunctions.NameFlip(SLCustomer.Name), 1, 50)) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxStrLen(SLCustomer.Name)

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Aug 18, 2025
@github-actions
Copy link
Contributor

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz JesperSchulz added processing-PR The PR is currently being reviewed and removed processing-PR The PR is currently being reviewed labels Aug 18, 2025
@github-actions
Copy link
Contributor

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz
Copy link
Contributor

Build fails with the following:

Test objects should be within the 130000..149999 range.

Looks like 147600.. is available. I'll try to re-ID and resubmit.

{
"name": "Intelligent Cloud Base",
"publisher": "Microsoft",
"version": "26.0.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency versions should be 27.0.0.0 everywhere.

"application": "26.0.0.0",
"idRanges": [
{
"from": 47200,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a valid ID range for tests. It must be between 130.000 and 149.999.

@JesperSchulz
Copy link
Contributor

Had to make some changes, but the code is now merged internally! I won't merge this PR, but with the next sync between ADO and GitHub, the changes will re-appear!

@blauerPCL
Copy link
Contributor Author

Had to make some changes, but the code is now merged internally! I won't merge this PR, but with the next sync between ADO and GitHub, the changes will re-appear!

Thank you! Sorry this was so much trouble. I didn't realize that test extensions were in a special range. I am assuming I should hold off on submitting any PRs for this extension until main has been updated with the new object Ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration GitHub request for Integration area processing-PR The PR is currently being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants