-
Notifications
You must be signed in to change notification settings - Fork 687
SL Migration - Initial upload for AL Test Tool test #28812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SL Migration - Initial upload for AL Test Tool test #28812
Conversation
…nto Plumbline-SL-VendorClassMigrationUpdate
…nto Plumbline-SL-InactiveCustomerVendorUpdate
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
1 similar comment
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
|
@nikolakukrika Here is the PR for the AL Test Tool tests for the SL Migration |
| else | ||
| CustomerBlocked := true; | ||
|
|
||
| if not CustomerDataMigrationFacade.CreateCustomerIfNeeded(SLCustomer.CustId, CopyStr(SLHelperFunctions.NameFlip(SLCustomer.Name), 1, 50)) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaxStrLen(SLCustomer.Name)
|
Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed. |
|
Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed. |
|
Build fails with the following: Test objects should be within the 130000..149999 range. Looks like 147600.. is available. I'll try to re-ID and resubmit. |
| { | ||
| "name": "Intelligent Cloud Base", | ||
| "publisher": "Microsoft", | ||
| "version": "26.0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency versions should be 27.0.0.0 everywhere.
| "application": "26.0.0.0", | ||
| "idRanges": [ | ||
| { | ||
| "from": 47200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid ID range for tests. It must be between 130.000 and 149.999.
|
Had to make some changes, but the code is now merged internally! I won't merge this PR, but with the next sync between ADO and GitHub, the changes will re-appear! |
Thank you! Sorry this was so much trouble. I didn't realize that test extensions were in a special range. I am assuming I should hold off on submitting any PRs for this extension until main has been updated with the new object Ids. |
Summary
Initial upload of AL Test Tool tests for the Dynamics SL Migration. This include tests for Accounting Periods, Customers, and Vendors.
Work Item(s)
Fixes # AB#565985
AB#567569
AB#567568
AB#574415