Skip to content

Conversation

@GediminasGaubys
Copy link
Contributor

@GediminasGaubys GediminasGaubys commented Jun 16, 2025

This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko

  • Added “Add customer as Shopify Location” action
  • Business logic to handle creation of company location from customer added
  • Added new Boolean field 'Manual Payment Gateway' field to 'Order Transaction' and 'Payment Method Mapping' tables.

Automated tests implemented

Fixes #26819

Fixes AB#581131

@GediminasGaubys GediminasGaubys requested a review from a team as a code owner June 16, 2025 14:04
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jun 23, 2025
@onbuyuka
Copy link
Contributor

onbuyuka commented Jul 9, 2025

@AndriusAndrulevicius great work, I added just a bit more comments to change. Thank you

…e related references in Company API and report
onbuyuka
onbuyuka previously approved these changes Jul 10, 2025
@JesperSchulz JesperSchulz added linked Issue is linked to a Azure Boards work item and removed linked Issue is linked to a Azure Boards work item labels Jul 10, 2025
…nit.al

Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
@JesperSchulz
Copy link
Contributor

@GediminasGaubys / @onbuyuka, I'm going on a summer break and won't be able to "babysit" this PR the coming weeks. The merge build failed on the following tests:

[2025-07-11 15:37:44] Failed tests:
[2025-07-11 15:37:44] Name: 
Method: TestCreateCompanyLocationSuccess
Time: 0.577
Message: 
Shopify Admin URL must have a value in Shopify Shop: Code=. It cannot be zero or empty.
StackTrace: 
Shpfy Communication Mgt.(CodeUnit 30103).CreateWebRequestURL line 2 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Communication Mgt.(CodeUnit 30103).CreateWebRequestURL line 2 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Communication Mgt.(CodeUnit 30103).ExecuteGraphQL line 10 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Communication Mgt.(CodeUnit 30103).ExecuteGraphQL line 4 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Communication Mgt.(CodeUnit 30103).ExecuteGraphQL line 6 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Company API(CodeUnit 30286).CreateCustomerAsCompanyLocation line 53 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Company API(CodeUnit 30286).CreateCompanyLocation line 19 - Shopify Connector by Microsoft version 27.0.36595.8552
Shpfy Company Locations Test(CodeUnit 139539).TestCreateCompanyLocationSuccess line 10 - Shopify Connector Test by Microsoft version 27.0.36595.8552
Test Runner - Mgt(CodeUnit 130454).RunTests line 26 - Test Runner by Microsoft version 27.0.36595.0
Test Runner - Isol. Codeunit(CodeUnit 130450).OnRun(Trigger) line 4 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunTests line 2 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunSelectedTests line 35 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunNextTest line 20 - Test Runner by Microsoft version 27.0.36595.0
Command Line Test Tool(Page 130455).RunNextTest - OnAction(Trigger) line 7 - Test Runner by Microsoft version 27.0.36595.0


Name: 
Method: TestCreateCompanyLocationCustomerAlreadyExportedAsCompany
Time: 0.014
Message: 
The Shopify Company does not exist. Identification fields and values: {3BCF51C9-595E-F011-8FBD-6045BDACC91D}
StackTrace: 
Shpfy Company Locations Test(CodeUnit 139539).TestCreateCompanyLocationCustomerAlreadyExportedAsCompany line 9 - Shopify Connector Test by Microsoft version 27.0.36595.8552
Test Runner - Mgt(CodeUnit 130454).RunTests line 26 - Test Runner by Microsoft version 27.0.36595.0
Test Runner - Isol. Codeunit(CodeUnit 130450).OnRun(Trigger) line 4 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunTests line 2 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunSelectedTests line 35 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunNextTest line 20 - Test Runner by Microsoft version 27.0.36595.0
Command Line Test Tool(Page 130455).RunNextTest - OnAction(Trigger) line 7 - Test Runner by Microsoft version 27.0.36595.0


Name: 
Method: TestCreateCompanyLocationCustomerAlreadyExportedAsLocation
Time: 0.01
Message: 
The Shopify Company Location does not exist. Identification fields and values: Id='11075'
StackTrace: 
Shpfy Company Locations Test(CodeUnit 139539).TestCreateCompanyLocationCustomerAlreadyExportedAsLocation line 9 - Shopify Connector Test by Microsoft version 27.0.36595.8552
Test Runner - Mgt(CodeUnit 130454).RunTests line 26 - Test Runner by Microsoft version 27.0.36595.0
Test Runner - Isol. Codeunit(CodeUnit 130450).OnRun(Trigger) line 4 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunTests line 2 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunSelectedTests line 35 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunNextTest line 20 - Test Runner by Microsoft version 27.0.36595.0
Command Line Test Tool(Page 130455).RunNextTest - OnAction(Trigger) line 7 - Test Runner by Microsoft version 27.0.36595.0


Name: 
Method: UnitTestDoMappingsOnAB2BShopifyOrder
Time: 0.223
Message: 
Assert.IsTrue failed. Order Mapping must succeed.
StackTrace: 
Library Assert(CodeUnit 130002).IsTrue line 3 - Library Assert by Microsoft version 27.0.36595.0
Shpfy Orders API Test(CodeUnit 139608).UnitTestDoMappingsOnAB2BShopifyOrder line 27 - Shopify Connector Test by Microsoft version 27.0.36595.8552
Test Runner - Mgt(CodeUnit 130454).RunTests line 26 - Test Runner by Microsoft version 27.0.36595.0
Test Runner - Isol. Codeunit(CodeUnit 130450).OnRun(Trigger) line 4 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunTests line 2 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunSelectedTests line 35 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunNextTest line 20 - Test Runner by Microsoft version 27.0.36595.0
Command Line Test Tool(Page 130455).RunNextTest - OnAction(Trigger) line 7 - Test Runner by Microsoft version 27.0.36595.0


Name: 
Method: UnitTestImportB2BShopifyOrderAndCreateSalesDocument
Time: 0.246
Message: 
Assert.IsTrue failed. Sales document is created from Shopify order
StackTrace: 
Library Assert(CodeUnit 130002).IsTrue line 3 - Library Assert by Microsoft version 27.0.36595.0
Shpfy Orders API Test(CodeUnit 139608).UnitTestImportB2BShopifyOrderAndCreateSalesDocument line 30 - Shopify Connector Test by Microsoft version 27.0.36595.8552
Test Runner - Mgt(CodeUnit 130454).RunTests line 26 - Test Runner by Microsoft version 27.0.36595.0
Test Runner - Isol. Codeunit(CodeUnit 130450).OnRun(Trigger) line 4 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunTests line 2 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunSelectedTests line 35 - Test Runner by Microsoft version 27.0.36595.0
Test Suite Mgt.(CodeUnit 130456).RunNextTest line 20 - Test Runner by Microsoft version 27.0.36595.0
Command Line Test Tool(Page 130455).RunNextTest - OnAction(Trigger) line 7 - Test Runner by Microsoft version 27.0.36595.0

@microsoft microsoft deleted a comment from github-actions bot Jul 15, 2025
@onbuyuka onbuyuka enabled auto-merge (squash) July 15, 2025 18:25
@onbuyuka onbuyuka disabled auto-merge July 15, 2025 18:26
onbuyuka
onbuyuka previously approved these changes Jul 15, 2025
@microsoft microsoft deleted a comment from github-actions bot Jul 15, 2025
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Jul 15, 2025
@aholstrup1 aholstrup1 merged commit b97f912 into microsoft:main Jul 28, 2025
1 check failed
@github-actions
Copy link
Contributor

Issue #26819 is not valid. Please make sure you link an issue that exists, is open and is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal] Shopify Contributions

6 participants