-
Notifications
You must be signed in to change notification settings - Fork 687
[Shopify] Connector - Company Location creation from Customer #28773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aholstrup1
merged 16 commits into
microsoft:main
from
GediminasGaubys:dev/jza/comp_loc_cust_mapping
Jul 28, 2025
Merged
[Shopify] Connector - Company Location creation from Customer #28773
aholstrup1
merged 16 commits into
microsoft:main
from
GediminasGaubys:dev/jza/comp_loc_cust_mapping
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod Mapping tables; update GraphQL query to include it
onbuyuka
requested changes
Jul 1, 2025
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Pages/ShpfyCompLocations.Page.al
Outdated
Show resolved
Hide resolved
onbuyuka
requested changes
Jul 1, 2025
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/PermissionSets/ShpfyObjects.PermissionSet.al
Outdated
Show resolved
Hide resolved
onbuyuka
requested changes
Jul 9, 2025
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyOrderMapping.Codeunit.al
Show resolved
Hide resolved
Contributor
|
@AndriusAndrulevicius great work, I added just a bit more comments to change. Thank you |
…e related references in Company API and report
onbuyuka
reviewed
Jul 10, 2025
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
previously approved these changes
Jul 10, 2025
Apps/W1/Shopify/test/Companies/ShpfyCompanyLocationsTest.Codeunit.al
Outdated
Show resolved
Hide resolved
…nit.al Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
Contributor
|
@GediminasGaubys / @onbuyuka, I'm going on a summer break and won't be able to "babysit" this PR the coming weeks. The merge build failed on the following tests: |
Apps/W1/Shopify/test/Companies/ShpfyCompanyLocationsTest.Codeunit.al
Outdated
Show resolved
Hide resolved
…n handling and GraphQL query
onbuyuka
previously approved these changes
Jul 15, 2025
Contributor
|
Issue #26819 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko
Automated tests implemented
Fixes #26819
Fixes AB#581131