Deprecate more finance rdlc reports

[daniel-williams-fenwick]

Summary

Replace references to deprecated RDLC finance reports with new Excel reports.

Some captions remain as (Preview) rather than (Excel) as clean tags already existed.

Work Item(s)

Fixes #28525

Related Base App PR - https://github.com/microsoft/BusinessCentralApps/pull/1363.

Fixes AB#591379

[github-actions]

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

[JesperSchulz]

Build error: EXRFinRoleCenter.PageExt.al(2,20): error AS0031: The action with name 'EXRVendorTopList' defined in PageExtension 'EXRFinRoleCenter' was found in the previous version, but is missing in the current extension. This will break dependent extensions.

[daniel-williams-fenwick]

Build error: EXRFinRoleCenter.PageExt.al(2,20): error AS0031: The action with name 'EXRVendorTopList' defined in PageExtension 'EXRFinRoleCenter' was found in the previous version, but is missing in the current extension. This will break dependent extensions.

Thanks @JesperSchulz I've setup AppSourceCop so I can detect these breaking changes, made the fix and checked for any others.

[daniel-williams-fenwick]

Also looks like some local builds don't compile with this:

App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountingManagerRC.PageExt.al(36,18): error AL0271: The action 'Action115' is not found in the target 'Accounting Manager Role Center'
App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRBookkeeperRC.PageExt.al(36,18): error AL0271: The action 'Action49' is not found in the target 'Bookkeeper Role Center'

@JesperSchulz I've changed where these addafters point to at Yusheng's suggestion and am praying they exist in all locales.

[AndreasHans]

In app.json please change the range from [4400..4420] to [4400..4440]

[AndreasHans]

Some build errors when trying to build and localize. Some of the actions referenced do not exist in all localizations. Instead I prefer that the groups are used instead and use addlast in these cases. Example use reporting group in case of detail trial balance.

App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(84,18): error AL0271: The action '"G/L Reports"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(95,18): error AL0271: The action '"Bu&dget"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(106,18): error AL0271: The action '"Customers and Vendors"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountingManagerRC.PageExt.al(25,18): error AL0271: The action '"Bu&dget"' is not found in the target 'Accounting Manager Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRBookkeeperRC.PageExt.al(14,18): error AL0271: The action '"A&ccount Schedule"' is not found in the target 'Bookkeeper Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRPurchasingManagerRC.PageExt.al(13,18): error AL0271: The action '"Vendor - Detail Trial Balance"' is not found in the target 'Purchasing Manager Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRGLAccountCard.PageExt.al(13,18): error AL0271: The action '"Detail Trial Balance"' is not found in the target 'G/L Account Card' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(13,18): error AL0271: The action '"Detail Trial Balance"' is not found in the target 'Chart of Accounts' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(24,18): error AL0271: The action '"Detail Trial Balance_Promoted"' is not found in the target 'Chart of Accounts' .

Additionally:
App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(26,23): error AL0725: The action type 'ActionRef' is not allowed in area 'None'
Here the action ref you want to add it after does not exist in some cases. Use use Category_Report in this case and addlast.

[daniel-williams-fenwick]

In app.json please change the range from [4400..4420] to [4400..4440]

Updated

[daniel-williams-fenwick]

Some build errors when trying to build and localize. Some of the actions referenced do not exist in all localizations. Instead I prefer that the groups are used instead and use addlast in these cases. Example use reporting group in case of detail trial balance.

App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(84,18): error AL0271: The action '"G/L Reports"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(95,18): error AL0271: The action '"Bu&dget"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountantRoleCenter.PageExt.al(106,18): error AL0271: The action '"Customers and Vendors"' is not found in the target 'Accountant Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRAccountingManagerRC.PageExt.al(25,18): error AL0271: The action '"Bu&dget"' is not found in the target 'Accounting Manager Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRBookkeeperRC.PageExt.al(14,18): error AL0271: The action '"A&ccount Schedule"' is not found in the target 'Bookkeeper Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\RoleCenters\EXRPurchasingManagerRC.PageExt.al(13,18): error AL0271: The action '"Vendor - Detail Trial Balance"' is not found in the target 'Purchasing Manager Role Center' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRGLAccountCard.PageExt.al(13,18): error AL0271: The action '"Detail Trial Balance"' is not found in the target 'G/L Account Card' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(13,18): error AL0271: The action '"Detail Trial Balance"' is not found in the target 'Chart of Accounts' App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(24,18): error AL0271: The action '"Detail Trial Balance_Promoted"' is not found in the target 'Chart of Accounts' .

Additionally: App\Apps\W1\ExcelReports\TempSource\app\src\Financials\PageExtensions\EXRChartOfAccounts.PageExt.al(26,23): error AL0725: The action type 'ActionRef' is not allowed in area 'None' Here the action ref you want to add it after does not exist in some cases. Use use Category_Report in this case and addlast.

@AndreasHans I've updated the files with build errors so that all of the new actions use addlast(reporting).

Let me know if you'd prefer I apply this to all actions across all of the Page Extensions instead.

[AndreasHans]

Error Message: The application object of type 'PageExtension' with the ID '4409' is defined in multiple apps. The apps are: Sales Order Agent by Microsoft 28.0.2147483647.2106; Dynamics BC Excel Reports by Microsoft 28.0.2147483647.2106.

Also no settings file is found

[daniel-williams-fenwick]

Error Message: The application object of type 'PageExtension' with the ID '4409' is defined in multiple apps. The apps are: Sales Order Agent by Microsoft 28.0.2147483647.2106; Dynamics BC Excel Reports by Microsoft 28.0.2147483647.2106.

Also no settings file is found

@AndreasHans I've updated the conflicting page extension id, but you told me to set the idranges to 4400..4440 in an earlier comment. Shouldn't that mean those id ranges are reserved for this app?

Could you please specify what the settings file should look like? I haven't created one for Microsoft before.

[AndreasHans]

Found some more ids that needs update:
4411 => 4440
4413 => 4441
4424 => 4442

and update the range to: 4400...4445

Ignore the comment about settings.json for now.

The id range specify which ids can be used by the app. However, these ranges can overlap with other apps

[AndreasHans]

Please resolve branch conflicts

[daniel-williams-fenwick]

ExcelReports app migrated. PR replicated in that repo here - microsoft/BCApps#4870