Test Result Analyzer fails if no stack trace is available#2257
Open
FreundDK wants to merge 14 commits into
Open
Test Result Analyzer fails if no stack trace is available#2257FreundDK wants to merge 14 commits into
FreundDK wants to merge 14 commits into
Conversation
Dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the AnalyzeTests action when a <failure> XML element has no stack trace content by switching from the XML "#text" accessor (which can be $null) to InnerText (empty string for empty nodes).
Changes:
- Replace
$failure."#text"with$failure.InnerTextwhen rendering and storing stack traces inGetTestResultSummaryMD.
Comment on lines
193
to
+198
| Write-Host " - Error: $($failure.message)" | ||
| Write-Host " Stacktrace:" | ||
| Write-Host " $($failure."#text".Trim().Replace("`n","`n "))" | ||
| Write-Host " $($failure.InnerText.Trim().Replace("`n","`n "))" | ||
| $testFailureNode = [FailureNode]::new($true) | ||
| $testFailureNode.errorMessage = $failure.message | ||
| $testFailureNode.errorStackTrace = $($failure."#text".Trim().Replace("`n","<br/> ")) | ||
| $testFailureNode.errorStackTrace = $($failure.InnerText.Trim().Replace("`n","<br/> ")) |
aholstrup1
reviewed
May 21, 2026
Collaborator
aholstrup1
left a comment
There was a problem hiding this comment.
LGTM. Missing a releasenote though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Fixes #2256
TestResultAnalyzer uses "#Text", which might be null instead of InnerText
This code shows what is wrong with that: