Skip to content

Make missing plugin repo errors more informative #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmytrovoytko wants to merge 5 commits into
base: master
Choose a base branch
from
+22 −1
Open

Make missing plugin repo errors more informative #4087

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d66adb
Make missing plugin repo errors more informative
dmytrovoytko May 6, 2026
b0d9a76
Make missing plugin repo errors more informative
dmytrovoytko May 6, 2026
905d192
Better message formatting
dmytrovoytko May 6, 2026
ec7d32d
Better message formatting
dmytrovoytko May 7, 2026
596c78d
Better message formatting
dmytrovoytko May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion internal/config/plugin_installer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,32 @@ func (pr PluginRepository) Fetch(out io.Writer) PluginPackages {
return PluginPackages{}
}
defer resp.Body.Close()

// Handle cases when plugin repo is not available
statusCode := resp.StatusCode
if statusCode == http.StatusForbidden {
fmt.Fprintf(out, "Skipped: %s\n", pr)
fmt.Fprintf(out, " Reason: Access to plugin repository is forbidden (Status Code: %d)\n", statusCode)
return PluginPackages{}
}
if statusCode == http.StatusNotFound {
fmt.Fprintf(out, "Skipped: %s\n", pr)
fmt.Fprintf(out, " Reason: Plugin repository not found (Status Code: %d)\n", statusCode)
return PluginPackages{}
}
if statusCode != http.StatusOK {
fmt.Fprintf(out, "Skipped: %s\n", pr)
fmt.Fprintf(out, " Reason: Unexpected status (Status Code: %d)\n", statusCode)
return PluginPackages{}
}

decoder := json5.NewDecoder(resp.Body)

var plugins PluginPackages
if err := decoder.Decode(&plugins); err != nil {
fmt.Fprintln(out, "Failed to decode repository data:\n", err)
fmt.Fprintf(out, "Skipped: %s\n", pr)
fmt.Fprintf(out, " Reason: Failed to decode repository data:\n")
fmt.Fprintf(out, " %s\n", err)
return PluginPackages{}
}
if len(plugins) > 0 {
Expand Down