deallocate rmw_init_options.enclave in rmw implementaion. #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Mar 6, 2025
|
I don't know this repo particularly well and maybe the PR will need to change because of the failing CI, but I rebuilt MotoROS2 with this PR included on the YRC1000, and the memory leak seems to be gone! |
Contributor
Author
|
@jimmy-mcelwain thanks for checking 👍 CI tells |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
deallocate-enclave
branch
from
92bc96f to
5b7d7a5
Compare
Contributor
Author
|
@pablogs9 this is CI green. |
pablogs9
reviewed
Mar 11, 2025
pablogs9
approved these changes
Mar 11, 2025
Contributor
Author
|
@pablogs9 thanks for the review, and merging! |
Contributor
Author
|
@Mergifyio backport humble |
Contributor
❌ Command disallowed due to command restrictions in the Mergify configuration.Details
|
Member
|
@mergify backport humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* deallocate rmw_init_options.enclave in rmw implementaion. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * implicit declaration of function ¡Ærcutils_strdup¡Ç Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit a698d4e)
pablogs9
pushed a commit
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #311
this is jazzy fix of #318, should be backported to humble as well.