boards: move board specific configurations #63

uLipe · 2022-07-26T22:25:19Z

Te idea is to keep consistent with other zephyr modules and separate board specific details into their own overlays.

Also add the example l475 IoT discovery board as an example.

No changes in the environment or build.

uLipe · 2022-07-26T22:25:57Z

@pablogs9 @Acuadros95 PTAL.

pablogs9 · 2022-07-27T06:13:26Z

Running CI, thanks a lot @uLipe

pablogs9 · 2022-07-27T06:13:40Z

@mergify backport foxy galactic main

mergify · 2022-07-27T06:13:58Z

backport foxy galactic main

✅ Backports have been created

Details

#76 boards: move board specific configurations (backport #63) has been created for branch foxy
#77 boards: move board specific configurations (backport #63) has been created for branch galactic
#78 boards: move board specific configurations (backport #63) has been created for branch main

pablogs9 · 2022-07-27T06:30:03Z

It seems to break the CI @uLipe : https://github.com/micro-ROS/micro_ros_zephyr_module/runs/7534484810?check_suite_focus=true#step:4:5888

uLipe · 2022-07-27T15:19:35Z

@pablogs9 my bad, during rebase I dropped a piece of the dts I will change this to draft while I fix it

uLipe · 2022-07-27T15:25:59Z

It seems the problem is more complex, the ucd node was introduced from zephyr version 2.7 , which is on my env for now.

For now I will make this compatible with 2.6 and figure later how to make the things to be compatible across the RTOS versions

pablogs9 · 2022-07-27T15:29:34Z

Thanks. Maybe we should investigate the working status of this module in 2.7 @Acuadros95

uLipe · 2022-07-27T16:15:41Z

@pablogs9 PTAL again, for now let's keep compatible with 2.6.

Actually I have this running on Zephyr 3.1 but using the overlay + kconfig updates that broke the CI + this PR ros2/rcutils#368

pablogs9 · 2022-07-28T05:55:14Z

Could you take a look at this #64 @uLipe. We would like to have this working with v3.1.0 as you have.

uLipe · 2022-07-28T15:31:55Z

@pablogs9 , @Acuadros95 , I just took the opportunity to modify the zephyr transport serial port to use the DT macros, label property in the devices are being removed from Zephyr and will not work in future kernel releases.

Please take another review and ask me any questions you might to have.

pablogs9 · 2022-07-29T06:06:45Z

I'll take a look on Monday when I have some hardware in the office

modules/libmicroros/microros_transports/serial-usb/microros_transports.c

pablogs9 · 2022-08-02T06:36:35Z

Hello @uLipe:

I have been able to test this with serial transport in disco_l475_iot1
Not able to build the serial-usb example
Should we drop the support for v2.4.0 if we merge this PR?

uLipe · 2022-08-02T12:31:48Z

Hi @pablogs9 my bad, I forgot to push the serial to usb commit to the PR will do it later and you will be able to test.

uLipe · 2022-08-02T15:45:13Z

@pablogs9 PTAL again, you may able to build serial usb now

uLipe · 2022-08-04T17:56:44Z

Hi @pablogs9 any updates regarding your tests?

About the Zephyr version I think it is safe to drop the 2.4 support, since most of V2 users would go to version 2.6 or 2.7, the last one is a LTS version.

There is no Zephyr-API breaking changes across 2.4 to 2.7, the same is not true for the build system for example, depending on what changed in a particular subsystem.

pablogs9 · 2022-08-05T06:20:42Z

Hello @uLipe, I'll check this on Monday in the office, because I have no boards right now.

Meanwhile, I would like to drop 2.4 and add 2.7 in this PR: #64 is it possible for you to take a look there?

pablogs9 · 2022-08-08T06:11:18Z

Hello @uLipe, I have been able to build the USB example but I have the following error:

*** Booting Zephyr OS build v2.6.0-rc1  ***
Failed to enable USB

Any idea? I'm working in the disco_l475_iot1

uLipe · 2022-08-10T18:47:47Z

@pablogs9 rebase, please check one more time.

CHANGELOG.rst

Signed-off-by: Felipe <felipe.neves@linaro.org>

port for serial transport. Signed-off-by: Felipe <felipe.neves@linaro.org>

uLipe · 2022-08-11T11:15:23Z

@pablogs9 fixed the changelog, please do a check again.

CHANGELOG.rst

pablogs9

LGTM, @Acuadros95 merge if you are ok

Acuadros95 · 2022-08-17T10:07:01Z

@uLipe Could you take a look at the CI? detail

/__w/micro_ros_zephyr_module/micro_ros_zephyr_module/micro_ros_zephyr_module/boards/disco_l475_iot1.conf:1: warning: attempt to assign the value 'y' to the undefined symbol USB
...

error: Aborting due to Kconfig warnings

uLipe · 2022-08-25T22:00:04Z

@pablogs9 sorry for the delay, since we dropped the version 2.6 the CONFIG_USB symbol was also deprecated, I will remove it and update the PR

replacing the CONFIG_USB symbol dropped in version 2.6 Signed-off-by: Felipe Neves <felipe.neves@linaro.org>

uLipe · 2022-08-25T22:22:41Z

@pablogs9 @Acuadros95 I added the Zephyr UDC0 nodelabel, which replaces the CONFIG_USB from version 2.7 and above, please approve the workflow when you have time.

boards/disco_l475_iot1.conf

CHANGELOG.rst

pablogs9 · 2022-08-26T06:12:57Z

@Acuadros95 PTAL and merger if you are ok

Acuadros95

LGTM

* 4.0.0 * boards: move board specifc details to its own folder Signed-off-by: Felipe <felipe.neves@linaro.org> * transports: use zephyr DT macros to set the serial port for serial transport. Signed-off-by: Felipe <felipe.neves@linaro.org> * boards: disco_l475_iot1: add zephyr UDC0 nodelabel replacing the CONFIG_USB symbol dropped in version 2.6 Signed-off-by: Felipe Neves <felipe.neves@linaro.org> * Update CHANGELOG.rst Signed-off-by: Felipe <felipe.neves@linaro.org> Signed-off-by: Felipe Neves <felipe.neves@linaro.org> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 7e07006)

Revert "boards: move board specific configurations (#63)" This reverts commit 7e07006. Signed-off-by: Antón Casas <antoncasas@eprosima.com>

* updates project to work with zephyr v4.0.x (#146) * updates project to work with zephyr v4.0.x * updating workflows for zephyr v4.0.x * adds cmake prefix path, changes to ci image * adds manual trigger to ci workflows * updates CI workflows for all active ROS2 distros * Get uart device with Zephyr 4's Devicetree-centric approach Signed-off-by: Antón Casas <antoncasas@eprosima.com> * Tested in v4.1.0 using manual installation on Ubuntu:24.04 base Docker image Signed-off-by: Antón Casas <antoncasas@eprosima.com> * Add v4.1.0 to CI and nightly Signed-off-by: Antón Casas <antoncasas@eprosima.com> * State SDK used in CI. Restore Z0rdon's info about docker image used. Signed-off-by: Antón Casas <antoncasas@eprosima.com> --------- Signed-off-by: Antón Casas <antoncasas@eprosima.com> Co-authored-by: Antón Casas <antoncasas@eprosima.com> (cherry picked from commit 7cbe6da) # Conflicts: # .github/workflows/nightly.yml # modules/libmicroros/microros_transports/serial/microros_transports.c * Solve merge conflicts Signed-off-by: Antón Casas <antoncasas@eprosima.com> * Harmonize device config with other branches Revert "boards: move board specific configurations (#63)" This reverts commit 7e07006. Signed-off-by: Antón Casas <antoncasas@eprosima.com> * Update ci.yml and nightly.yml Signed-off-by: Antón Casas <antoncasas@eprosima.com> --------- Signed-off-by: Antón Casas <antoncasas@eprosima.com> Co-authored-by: Zordon <101883124+Z0rdon@users.noreply.github.com> Co-authored-by: Antón Casas <antoncasas@eprosima.com>

pablogs9 requested review from Acuadros95 and pablogs9 July 27, 2022 06:13

uLipe changed the title ~~boards: move board specific configurations~~ draft: boards: move board specific configurations Jul 27, 2022

uLipe marked this pull request as draft July 27, 2022 15:20

uLipe force-pushed the feature/board_specific branch from d06e442 to f5c6986 Compare July 27, 2022 16:13

uLipe changed the title ~~draft: boards: move board specific configurations~~ boards: move board specific configurations Jul 27, 2022

uLipe marked this pull request as ready for review July 27, 2022 16:13

uLipe mentioned this pull request Jul 28, 2022

Move support to v2.7.x and v3.1.0 #64

Merged

uLipe force-pushed the feature/board_specific branch from f5c6986 to 45bfc52 Compare July 28, 2022 15:30

pablogs9 requested changes Aug 2, 2022

View reviewed changes

modules/libmicroros/microros_transports/serial-usb/microros_transports.c Outdated Show resolved Hide resolved

modules/libmicroros/microros_transports/serial-usb/microros_transports.c Show resolved Hide resolved

uLipe force-pushed the feature/board_specific branch from 45bfc52 to f1b89c7 Compare August 2, 2022 15:44

uLipe requested a review from pablogs9 August 2, 2022 23:54

uLipe force-pushed the feature/board_specific branch 2 times, most recently from a26502f to ad2f02b Compare August 10, 2022 18:42

pablogs9 requested changes Aug 11, 2022

View reviewed changes

CHANGELOG.rst Show resolved Hide resolved

pablogs9 and others added 3 commits August 11, 2022 08:14

4.0.0

7cea18a

boards: move board specifc details to its own folder

c67b2e8

Signed-off-by: Felipe <felipe.neves@linaro.org>

transports: use zephyr DT macros to set the serial

af8165d

port for serial transport. Signed-off-by: Felipe <felipe.neves@linaro.org>

uLipe force-pushed the feature/board_specific branch from ad2f02b to af8165d Compare August 11, 2022 11:14

pablogs9 reviewed Aug 11, 2022

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

pablogs9 approved these changes Aug 11, 2022

View reviewed changes

boards: disco_l475_iot1: add zephyr UDC0 nodelabel

7266123

replacing the CONFIG_USB symbol dropped in version 2.6 Signed-off-by: Felipe Neves <felipe.neves@linaro.org>

uLipe force-pushed the feature/board_specific branch from 15d8ae4 to 7266123 Compare August 25, 2022 22:20

pablogs9 approved these changes Aug 26, 2022

View reviewed changes

boards/disco_l475_iot1.conf Outdated Show resolved Hide resolved

pablogs9 reviewed Aug 26, 2022

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

Update CHANGELOG.rst

8dc5de5

Acuadros95 approved these changes Aug 26, 2022

View reviewed changes

Acuadros95 merged commit 7e07006 into micro-ROS:humble Aug 26, 2022

mergify bot mentioned this pull request Aug 26, 2022

boards: move board specific configurations (backport #63) #76

Closed

This was referenced Aug 26, 2022

boards: move board specific configurations (backport #63) #77

Closed

boards: move board specific configurations (backport #63) #78

Open

4ntn added a commit that referenced this pull request Mar 17, 2025

Harmonize device config with other branches

cf29aa1

Revert "boards: move board specific configurations (#63)" This reverts commit 7e07006. Signed-off-by: Antón Casas <antoncasas@eprosima.com>

boards: move board specific configurations #63

boards: move board specific configurations #63

Uh oh!

Conversation

uLipe commented Jul 26, 2022

Uh oh!

uLipe commented Jul 26, 2022

Uh oh!

pablogs9 commented Jul 27, 2022

Uh oh!

pablogs9 commented Jul 27, 2022

Uh oh!

mergify bot commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

pablogs9 commented Jul 27, 2022

Uh oh!

uLipe commented Jul 27, 2022

Uh oh!

uLipe commented Jul 27, 2022

Uh oh!

pablogs9 commented Jul 27, 2022

Uh oh!

uLipe commented Jul 27, 2022

Uh oh!

pablogs9 commented Jul 28, 2022

Uh oh!

uLipe commented Jul 28, 2022

Uh oh!

pablogs9 commented Jul 29, 2022

Uh oh!

Uh oh!

Uh oh!

pablogs9 commented Aug 2, 2022

Uh oh!

uLipe commented Aug 2, 2022

Uh oh!

uLipe commented Aug 2, 2022

Uh oh!

uLipe commented Aug 4, 2022

Uh oh!

pablogs9 commented Aug 5, 2022

Uh oh!

pablogs9 commented Aug 8, 2022

Uh oh!

uLipe commented Aug 10, 2022

Uh oh!

Uh oh!

uLipe commented Aug 11, 2022

Uh oh!

Uh oh!

pablogs9 left a comment

Choose a reason for hiding this comment

Uh oh!

Acuadros95 commented Aug 17, 2022

Uh oh!

uLipe commented Aug 25, 2022

Uh oh!

uLipe commented Aug 25, 2022

Uh oh!

Uh oh!

Uh oh!

pablogs9 commented Aug 26, 2022

Uh oh!

Acuadros95 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mergify bot commented Jul 27, 2022 •

edited

Loading