Skip to content

Conversation

@shvass
Copy link
Contributor

@shvass shvass commented Aug 2, 2024

atomic patch no more deletes current working directory

atomic patch no more deletes current working directory
@pablogs9
Copy link
Member

Why this order change solves your issue?

@shvass
Copy link
Contributor Author

shvass commented Sep 8, 2024

well, here libmicroros.mk the path specified to rm command happens to be the current working directory, which results in uncertain behavior.

just switching to another directory before performing rm fixes the issue

@pablogs9 pablogs9 merged commit 002cbc1 into micro-ROS:jazzy Sep 9, 2024
@pablogs9
Copy link
Member

pablogs9 commented Sep 9, 2024

@mergify backport humble iron

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

backport humble iron

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify bot mentioned this pull request Sep 9, 2024
mergify bot pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify bot mentioned this pull request Sep 9, 2024
pablogs9 pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
pablogs9 pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
@4ntn
Copy link
Contributor

4ntn commented Jun 5, 2025

@mergify backport rolling

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025

backport rolling

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 5, 2025
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify bot mentioned this pull request Jun 5, 2025
4ntn pushed a commit that referenced this pull request Jun 5, 2025
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants