add support for ADC buttons that pulls down to 0, to class BfButtonManager #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some shields e.g. the DFR0009 by DFRobot https://wiki.dfrobot.com/LCD_KeyPad_Shield_For_Arduino_SKU__DFR0009 Include buttons that pull down to 0V when pressed. This change adds support for these buttons.
Some shields e.g. the DFR0009 by DFRobot https://wiki.dfrobot.com/LCD_KeyPad_Shield_For_Arduino_SKU__DFR0009 Include buttons that pull down to 0V when pressed. This change adds support for these buttons.
Some shields e.g. the DFR0009 by DFRobot https://wiki.dfrobot.com/LCD_KeyPad_Shield_For_Arduino_SKU__DFR0009 include buttons that pull down to 0V when pressed. This change adds support for these buttons.
Add note indicating what is modified in this fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some shields e.g. the DFR0009 by DFRobot
https://wiki.dfrobot.com/LCD_KeyPad_Shield_For_Arduino_SKU__DFR0009
include buttons that pull down to 0 when pressed.
This change adds support for this type of button.
The current master code allows the upper bound (resolution) to be set, but the lower bound is hard coded as 100.
Added _adcLowerBound to class BfButtonManager, with method to set it (setADCBounds).
_adcLowerBound defaults to 100 (current hard coded value).