fix: remove broken greet-new-contributors workflow#77
Merged
Conversation
The actions/first-interaction greeting still referenced the upstream invisible-squiggles template and posted off-brand bot comments on new issues and PRs.
Review Summary by QodoRemove broken greet-new-contributors workflow
WalkthroughsDescription• Removes broken greet-new-contributors workflow file • Deletes outdated actions/first-interaction@v3 configuration • Removes yamllint exception for deleted workflow • Eliminates off-brand bot comments on issues/PRs Diagramflowchart LR
A["greet-new-contributors.yml<br/>with stale config"] -- "delete" --> B["Workflow removed"]
C["yamllint config<br/>with exception"] -- "update" --> D["Exception removed"]
B --> E["No bot comments<br/>on new issues/PRs"]
D --> E
File Changes1. .github/workflows/greet-new-contributors.yml
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .yamllint configuration by removing the .github/workflows/greet-new-contributors.yml file from the line-length ignore list, ensuring it now adheres to the standard 100-character limit. No review comments were provided for these changes, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/greet-new-contributors.yml, which usedactions/first-interaction@v3with stale copy from the upstreaminvisible-squigglestemplate.achshould work from within Git worktrees #73 (achshould work from within Git worktrees #73 (comment)).Test plan
greet new contributorsworkflow runs on new issues/PRsSee also