Improve the IndexStoreFinder architecture and testability #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏗️ Improve Architecture & Add Comprehensive Test Coverage
Summary
This MR refactors the
IndexStoremodule with protocol-based abstractions, enabling full testability while maintaining the same runtime behavior. Adds 800+ lines of new tests covering the core symbol search functionality.Changes
🎯 Architecture Improvements
IndexStoreProviding.swiftIndexStore,UnitReader,RecordReader, andSymbolOccurrenceIndexStore+Providing.swiftRecordIndex.swiftSymbolQuery.swiftSymbolKind+Parsing.swiftSymbolKindparsing into a clean extensionSymbolMatching.swift✅ Test Coverage Added
IndexStoreFinderTests.swiftRecordIndexTests.swiftSymbolQueryTests.swift🔧 Other Changes
0.1.5→0.2.1ThreadSafeSetfor cleaner concurrent result collection@preconcurrency import IndexStorefor Swift 6 compatibilityWhy This Matters