Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
316 commits
Select commit Hold shift + click to select a range
ecb7932
Move bulk of the code to cxx to not expose extra headers
shahor02 Jun 23, 2025
a096a62
GPU/TPCClusterFinder: Fix out-of-bounds write.
fweig Jun 20, 2025
53b81b8
Fix for cluster flags
ChSonnabend Jun 25, 2025
312ae13
Cleanup + handling of deconvolution
ChSonnabend Jun 25, 2025
eb292d8
Using only propagateMcLabels
ChSonnabend Jun 25, 2025
d8dbc60
ITS: cleanup unused GPU code
f3sch Jun 23, 2025
96dafaa
ITS: GPU add missing output to GPUWorkflowSpec
f3sch Jun 19, 2025
38acc6f
DPL Analysis: add `DefinesDelayed`
aalkin Jun 26, 2025
aa1ca7a
DPL: improve logs for new calibration scheme (#14030)
ktf Jun 26, 2025
cc7a23d
jobutils: Sanitize return code treatment
sawenzel Jun 26, 2025
e4108ce
A3: Add sensitive RICH layers to geometry (#14450)
njacazio Jun 26, 2025
8d6b1cc
DPL: avoid unintialised member (#14449)
ktf Jun 26, 2025
bb740a4
Replace type name hash with a different string hash in preparation fo…
aalkin Jun 26, 2025
e2c7873
Bump actions/setup-python from 2 to 5 (#14299)
dependabot[bot] Jun 27, 2025
6df9860
Bump actions/stale from 1 to 9
dependabot[bot] May 20, 2025
f3a41fc
Bump actions/checkout from 3 to 4
dependabot[bot] May 20, 2025
cddd928
Fix vertex copying for last timeframe in collisioncontext
sawenzel Jun 27, 2025
50d26e3
o2-sim: Fix for merger exit status analysis
sawenzel Jun 27, 2025
6f78cf3
DPL Analysis: add `PresliceGroup` (#14418)
aalkin Jun 30, 2025
11329f6
Improve filling kernel speed by 20x using for-loop fill on CPU
ChSonnabend Jun 30, 2025
fe73d1b
TPC reco: Only read CTP digits when tracking
sawenzel Jun 26, 2025
bb7db6d
ITS: GPU: print kernel params
f3sch May 17, 2025
2bf4a15
ITS: GPU use ms for tracklets
f3sch Jun 30, 2025
fdc30b1
ITS: add GPUTimer and use streams
f3sch Jun 9, 2025
4cfc7e4
DPL: make sure devices with Sporadic inputs get sorted last, if possi…
ktf Jul 1, 2025
bf8eb6f
OpenCL: Propagate number of host threads to PoCL runtime.
fweig Jul 1, 2025
678b1ae
GPU Display: Fix typo in Vulkan version check
davidrohr Jul 2, 2025
af304de
DPL: add signposts replacement for LOG(alarm) / LOG(important) (#14468)
ktf Jul 2, 2025
76543b9
Reset ITS tracks ROF counters if not tracks found
shahor02 Jul 2, 2025
5b28f57
CommonUtils: Don't use ROOT TGrid if we build standalone benchmark
davidrohr Jul 1, 2025
925c580
Fix bug in weight filling (#14461)
jgrosseo Jul 3, 2025
9fa8cf5
GPU QA: Add Correctly Attached non-fake normalized cluster count§
davidrohr Jul 2, 2025
e629c0a
GPU Standalone CI: Test also build without ROOT/VC/FMT/ONNX
davidrohr Jul 2, 2025
e68f207
DPL: improve debugging for rate limiting
ktf Jul 2, 2025
eb67b94
DPL: move rate limiter to use signposts rather than log messages.
ktf Jul 2, 2025
ad44565
[EMCAL-567] Add class to handle EMCal temperature calibration
Jul 1, 2025
8c105b5
Update CODEOWNERS
sawenzel Jul 2, 2025
434fb27
[EMCAL-567] Fix 1/3 SM numbers (#14477)
jokonig Jul 3, 2025
ab99262
GPU Standalone CI: Build also event display
davidrohr Jul 3, 2025
0c3f2b5
Feat: add skeleton for GPUErrorQA task
ariedel-cern Feb 14, 2025
b83d673
Feat: add GPUErrorQA class
ariedel-cern Mar 6, 2025
7b8b2e7
Feat: movde error names to GPUErrors.h
ariedel-cern Jun 12, 2025
8aec6f6
Fix: expose gpu error names with static function
ariedel-cern Jun 17, 2025
7b5af49
Feat: account for missing error codes
ariedel-cern Jun 17, 2025
c2f066a
Fix: add header guard
ariedel-cern Jul 3, 2025
bc3e04c
GPU: Update build documentation for new gpu-system.sh package
davidrohr Jul 4, 2025
e289430
Add/use in TPCFastTransform mean IDC data member on top of Lumi
shahor02 Jul 1, 2025
b562533
TRD: decrease default --max-delay for gain, t0, vdexb calibrations
ehellbar Jul 4, 2025
8b07c99
Vtx: make class printable
f3sch Jun 24, 2025
9cef6de
Computation of DCAxyz for forward tracks (#14460)
mcoquet642 Jul 4, 2025
9ce304b
ALICE3-TRK: detector ID used to fill Hit information correctly retrie…
atriolo Jul 4, 2025
7bbe964
DPL: rename log stream to check sockets activity
ktf Jul 4, 2025
d807214
DPL: add signposts with log-level detail.
ktf Jul 5, 2025
2a7442d
GPU Standalone CI: With the new build container, we can also build Vu…
davidrohr Jul 4, 2025
d9d6894
TPC QA: Separate normalized attached counts for non-fake and all tracks
davidrohr Jul 6, 2025
b05744a
DPL: improve debug information in case of circular dependencies.
ktf Jul 8, 2025
dd12eda
DPL: remove duplicate branch.
ktf Jul 8, 2025
1071e77
DPL: fix missing return true in ToologyPolicy
ktf Jul 8, 2025
1f08dbe
[ITS3] Fix Y position of ITS3 clusters and hits (#14483)
fgrosa Jul 8, 2025
5a776ff
Feat: add ratio plots to TrackClusters QA task
ariedel-cern Jul 4, 2025
00b201b
New methods to query AggregatedRunInfo for MC
sawenzel Jun 3, 2025
2dbe3ff
Update AggregatedRunInfo.cxx
sawenzel Jul 8, 2025
1013f69
Make O and Ne nuclei known to LHCIF processor (#14494)
shahor02 Jul 9, 2025
9d56f5d
DPL: fixes for dependency checks of devices with sporadic inputs in T…
ehellbar Jul 9, 2025
fe1d400
keeping the previous logic that output-proxies should be last
ehellbar Jul 9, 2025
aee6833
explicit call to Sumw2 (cosmetic only)
jgrosseo Jul 10, 2025
2f7ce66
GPU: Use warp barriers in ZS decoder.
fweig Jun 23, 2025
7d9bcd8
ITS: fix seeding vertex labels
f3sch Jun 26, 2025
1232a95
ITS: Vertexer return early and only one arena
f3sch Jun 18, 2025
6522275
ITS: unify configuration of algorithms
f3sch Jun 8, 2025
82d072d
ITS: prefer config params over cli
f3sch Jun 8, 2025
980e564
TrackReference: possibility to have unknown DetectorID
sawenzel Jul 9, 2025
0d508b3
AOD: TrackQA use outer ITS ref. for residuals to TPC
f3sch Jul 9, 2025
c26672b
ITS: remove some printing
f3sch Jun 24, 2025
6665ddd
ITS: fix TypedAllocator for cuda thrust
Jul 9, 2025
53be5c4
GPU Display OpenGL Backend: Use nullptr instead of 0
davidrohr Jul 11, 2025
28d2dc3
GPU QA: Make cluster cuts setable and adust defaults
davidrohr Jul 11, 2025
662f864
ITS: add truth seeding
f3sch Jun 19, 2025
0c0f2b9
ITS: Vertexer remove unused code (#14508)
f3sch Jul 14, 2025
6d2c1d3
ITS: opt. vertex cont. output (#14507)
f3sch Jul 14, 2025
3c7f531
ITS: allow overriding number of iterations for tracker
f3sch Jul 1, 2025
30b301e
ITS: disable reco via configParams
f3sch Jul 4, 2025
5b80bab
Add missing TPCNClsPID dynamic columns (#14503)
mpuccio Jul 15, 2025
0c69826
HepMC: Remove default backgrounding mode
sawenzel Jul 12, 2025
38e8f24
DPL: drop unneeded headers.
ktf Jul 15, 2025
36f656b
Add LIGHTNUCLEI flag, extend pp settings on BEAMTYPE leading to LIGHT…
shahor02 Jul 15, 2025
664d682
dpl-workflow: Fix logic to mlock shm segments
davidrohr Jul 16, 2025
92375f9
Extend run-time-span-file and invert-irframe-selection TF selections …
shahor02 Jul 16, 2025
dfd37f9
GPU: Fix checking for dmaTransferType with GPU memory registration di…
davidrohr Jul 16, 2025
bbb5bb8
GPU: Fix typo in getting default number of threads from env variables
davidrohr Jul 17, 2025
d238d41
TPCFastTransformation: Resolve recursion at compile time with templat…
fweig Jul 17, 2025
5d72482
ITS: cleanup unused classes
f3sch Jul 2, 2025
5074d71
TRD: fix missing include
f3sch Jul 13, 2025
5cdac2f
ITS: fix CookedTracker due to memory refactor
f3sch Jul 14, 2025
aaf3d53
DPL: get rid of gsl::span.
ktf Jul 17, 2025
2db9446
DPL: move topological sort in a separate file
ktf Jul 16, 2025
9b9ef9a
Propagating merged noise map to DCS (#14515)
nivram-phy Jul 18, 2025
da3a178
NN clusterizer: Improve filling kernel speed (#14510)
ChSonnabend Jul 18, 2025
51d4f86
Add fully qualified names for std::string and std::map
mrtineide Jul 18, 2025
c1b57b1
Script cleanup: use -n instead of ! -z
davidrohr Jul 18, 2025
7423aa7
TPC: Avoid using deprecated fmt::localtime
davidrohr Jul 18, 2025
8252a1f
DPL: out of line metrics related methods
ktf Jul 18, 2025
b8d6494
ITS: cleanup lines and tracklet/clusterlines changes (#14511)
f3sch Jul 21, 2025
d53e9d9
IWYU: TimeDeadMap.h
vkucera Jul 9, 2025
ac2ac36
ITS: print deltaRof option (#14531)
f3sch Jul 22, 2025
3922d50
ITS: add CheckDROF macro (#14533)
f3sch Jul 22, 2025
792df66
ITS: fix opt. label output if firstOrbit!=0 (#14532)
f3sch Jul 22, 2025
a69009b
Eov for orbitreset (#14534)
lietava Jul 23, 2025
6cd3538
Added Lambda1520 PDG code to PhysicsConstants.h (#14377)
hkoley Jul 23, 2025
7fce8d8
ITS: last mod. for deltaROF and perVertex (#14538)
f3sch Jul 23, 2025
02b6dc2
Fix alignment so that jemalloc / address sanitizer do no complain
ktf Jul 23, 2025
76f5dc4
[MFT] read track covariances from AO2Ds
aferrero2707 Apr 8, 2025
b733857
ITS: GPU: fix perVtx + upc iteration + atomic level update
f3sch Jul 23, 2025
723aeb3
ITSMFT: FST opt. rerun clusterizer
f3sch Jul 24, 2025
84dd75d
Fix coding rule violation
davidrohr Jul 26, 2025
6f47846
Add Lambda1405 to TDatabasePdg and O2MCApplication (#14506)
fmazzasc Jul 28, 2025
69f6737
NN clusterizer: Bug-fixes and adding deterministic mode (#14530)
ChSonnabend Jul 28, 2025
9907116
Make max Xiu for pre-propagation settable (#14544)
ddobrigk Jul 29, 2025
0975a95
DataFormats: Add V0Type (#14547)
f3sch Jul 29, 2025
30e53d0
Account for TPC clusters non-monotonous sorting
shahor02 Jul 18, 2025
7fa6785
GPU: GPUd --> GPUdii Force Inline, Code did not break
vikasssinghal Jul 30, 2025
d55013b
Add hash method to the TrackParam
shahor02 Jul 30, 2025
de1a1d6
Add track hash to TrackStudy output
shahor02 Jul 30, 2025
fd6d4eb
dpl-workflow: simple serialization mitigation seems not to work on MI…
davidrohr Jul 31, 2025
c01e120
ITS: if TF dropped clear tracks (#14553)
f3sch Jul 31, 2025
5cae1bc
Bug-fix for memory allocation (#14554)
ChSonnabend Jul 31, 2025
1aa2c14
TOF Param container: move to header only
njacazio Jul 15, 2025
f08023c
ITS: allow to Individually set kernel parameters
f3sch Jul 31, 2025
afc3e67
ITS: Tracklet add print compatible on GPU
f3sch Aug 4, 2025
8feebaa
ITS: format time for TF
f3sch Aug 4, 2025
0a6a962
ITS: make trackleting compatible with GPU (partial revert)
f3sch Aug 4, 2025
c62aef2
ITS: GPU: fix deltaROF tracking
f3sch Aug 4, 2025
0e23762
added socket communication (#14529)
jmyrcha Aug 5, 2025
83467b3
DPL: move to std::pmr where possible
ktf Jun 18, 2025
1f48261
DPL: add component for Arrow Acero Streaming Engine
ktf Jul 24, 2025
28345fb
Get rid of C++ extension warning
ktf Aug 7, 2025
1f0e874
DPL tests: drop unneeded includes
ktf Aug 7, 2025
87ef0fc
DPL: drop more boost_test usage
ktf Aug 7, 2025
00279c7
DPL CCDB: move helper initialisation to a separate function
ktf Aug 7, 2025
6209646
DPL Analysis: fix hash calculation for the string_views
aalkin Jun 30, 2025
7129f45
DPL Analysis: add parsing of expressions from strings
aalkin Jun 30, 2025
81851e7
move unnecessary statics to .cxx
aalkin Jun 30, 2025
59033a5
Allow filters to be set in init(); Add ability to set a filter from s…
aalkin Jun 30, 2025
db916c2
DPL Analysis: add support for BinaryView columns
ktf Aug 8, 2025
f2b0957
ITS: GPU: put trackleting properly on different streams
f3sch Aug 6, 2025
2498a68
ITS: GPU: put cell finding on different streams
f3sch Aug 6, 2025
853e48d
ITS: GPU: put cell neighbour finding on different streams
f3sch Aug 6, 2025
0825b22
ITS: GPU: use external allocator for temp storage
f3sch Aug 7, 2025
7b7d8ff
ITS: GPU: simplify stream synchronization
f3sch Aug 7, 2025
80c4d14
ITS: GPU: resolve added TODOs
f3sch Aug 8, 2025
a4e3e15
Fix TimingInfo.timeslice vs DPH.startTime mismatch
shahor02 Aug 10, 2025
24f1796
DPL: improve error message
ktf Aug 10, 2025
9192856
use generic get() in row_helpers
mytkom Sep 8, 2024
cfbfb13
backward compatibility for binning policy
mytkom Sep 9, 2024
73793c8
Fix after rebase
saganatt Jan 9, 2025
aec2bdb
Further simplification and compilable code
saganatt Jan 13, 2025
c1e321b
Remove probably redundant check. To be checked
saganatt Apr 30, 2025
5df80a7
Please consider the following formatting changes
alibuild Jul 11, 2025
3e0d913
Optionally store CTP lumi scaler (norm to 1s) in CTP digitizer output
shahor02 Aug 10, 2025
26acde4
DPL: add C++20 ranges views to filter vectors of InputSpecs / OutputS…
ktf Aug 12, 2025
a4605d0
[MCH] improvements to the pedestal calibrator
aferrero2707 Aug 12, 2025
e96552a
Update README so example code has std::
mrtineide Aug 13, 2025
a1c484d
Ctpdev: reducing logs in run manager (#14574)
lietava Aug 13, 2025
f9fa54e
DPL: add benchmark for stack creation
ktf Aug 13, 2025
bbef7a7
Data Model: provide size when deallocating a Stack
ktf Aug 13, 2025
999ac71
Make sure extra tracks are randomized to avoid PHOS hole losses
shahor02 Aug 13, 2025
1463e66
ITS: add common vertex definition and neighbours per road
f3sch Aug 14, 2025
947b41b
Revert "Data Model: provide size when deallocating a Stack"
ktf Aug 14, 2025
fe9e226
Revert "DPL: move to std::pmr where possible"
ktf Aug 14, 2025
3cafea0
Revert "Fix alignment so that jemalloc / address sanitizer do no comp…
ktf Aug 14, 2025
65275d9
DPL Analysis: use offset cache for sorted grouping (#14571)
aalkin Aug 14, 2025
dce7e0e
Skip QED events in TPC QA
shahor02 Aug 14, 2025
6c35d65
DPL: add more views on InputSpecs / OutputSpecs / DataProcessors (#14…
ktf Aug 15, 2025
c35a2cd
Geo: optional print out alignment matrices
f3sch May 27, 2025
44cd710
Align: print delta frame and level
f3sch May 27, 2025
3912592
Align: Fix using local delta matrix
f3sch Aug 15, 2025
7262c36
Fix in TRD sector getter
shahor02 Aug 15, 2025
0364324
ITS: GPU: prepare to lazy loading of data (#14585)
f3sch Aug 18, 2025
cd8e576
DPL Analysis: add an example of the string filter (#14570)
aalkin Aug 18, 2025
fa7d8f9
Revert "Fix in TRD sector getter"
shahor02 Aug 18, 2025
86424f9
DPL Analysis: support configurables in string expressions (#14598)
aalkin Aug 18, 2025
d4e16e1
ITS: GPU: overlap memcpy with compute kernels (#14596)
f3sch Aug 18, 2025
fb4df11
ITS: template Tracker, Cell and Road (#14597)
f3sch Aug 18, 2025
556556a
ZDC: Add getter for hit secondary flag
fcatalan92 Jul 30, 2025
6b6098b
ITS: create artefacts labels only on demand (#14594)
f3sch Aug 19, 2025
89bef8a
DPL: don't print INVALID runNumber error when running with ALICE_O2_F…
ehellbar Aug 19, 2025
be990f7
DPL Analysis: fix for retrieving placeholder nodes in filters parsed …
aalkin Aug 20, 2025
396c2c4
Add sapling to the .gitignore (#14605)
ktf Aug 20, 2025
d84a22c
DPL: make addInputs support anything which provides base_specs (#14575)
ktf Aug 20, 2025
9b8fb23
TPC: Add scaling of VDrift with T/P (#14602)
matthias-kleiner Aug 21, 2025
06c1b84
Enable ROOT file output in TPC chunked-digit merger (#14608)
sawenzel Aug 21, 2025
df10dd3
DPL Analysis: rework cursor logic keeping the `gsl::span` for VLAs (#…
aalkin Aug 21, 2025
95f677e
Adding sigma=0 cluster handling
ChSonnabend Aug 21, 2025
da20bb7
fix
ChSonnabend Aug 21, 2025
ec334bc
fix
ChSonnabend Aug 21, 2025
7fccf1d
[MFT] Fixing wrong call of functions in construction of NoiseMaps (#1…
mcoquet642 Aug 22, 2025
b319a5f
ITS: GPU: disallow nROFsPerIterations (#14614)
f3sch Aug 23, 2025
d823a46
Ctpdev: validity of orbitreset (#14612)
lietava Aug 24, 2025
3e1afe2
Method to translate TOF cluster to nominal sector frame
shahor02 Aug 24, 2025
38a4549
Add residuals for external detectors unless --skip-ext-det-residuals …
shahor02 Aug 17, 2025
8e29142
GPU Workflow: Don't load ITS geometry when ITS is not used
davidrohr Aug 20, 2025
1eb10b8
GPU Workflow: Do not do calib requests / updates in gpu-reconstructio…
davidrohr Aug 20, 2025
4a450cf
GPU HIP: Ignore comments in hipification template file check
davidrohr Aug 22, 2025
c86ea4e
TPC Workflow: Don't write triggerwords if they are not created
davidrohr Aug 19, 2025
012946b
GPU CMake: Force using alidist GCC for host compilation of CUDA/HIP code
davidrohr Aug 14, 2025
d375e63
DPL Analysis: centralised CCDB support in analysis (#14567)
ktf Aug 25, 2025
408665d
Add missing includes
njacazio Aug 25, 2025
2d53aee
another fix
njacazio Aug 25, 2025
bd748b7
Revert "Skip QED events in TPC QA"
davidrohr Aug 25, 2025
88321c2
Minor fixes of debug printouts
davidrohr Aug 25, 2025
5042672
GPU QA: Proper fix for fetching timebins of MC data
davidrohr Aug 25, 2025
7278b4e
TPC: sort buffer of pressure in case it is not sorted
matthias-kleiner Aug 25, 2025
de1d18e
start_tmux.sh: use o2-ccdb.internal for ccdb requests
ehellbar Aug 25, 2025
e1ff911
Add HBFUtilsConfig to allow standalone aggregation of TPC residuals
shahor02 Aug 26, 2025
a4dd82a
Fix alignment so that jemalloc / address sanitizer do no complain
ktf Jul 23, 2025
ff42ca2
Data Model: provide size when deallocating a Stack
ktf Aug 13, 2025
dec2fe8
A3: Add customization of detector MID/Magnet/Absorber radius (#14621)
njacazio Aug 27, 2025
8735573
ALICE3-TRK: first version of working digitizer (#14619)
atriolo Aug 27, 2025
6d863f4
ITS: template Vertexer&Traits, IndexTableUtils (#14606)
f3sch Aug 27, 2025
ad2098c
GPU: Rename misleading variable
davidrohr Aug 26, 2025
3673ef7
ITS: cell neighbour step use atomicMax (#14595)
f3sch Aug 27, 2025
cfa791d
add best knowldge of collision time in tof matching info (#14615)
noferini Aug 27, 2025
577a7f0
ITS: skip processing entirely if no clusters/rofs in TF (#14629)
f3sch Aug 27, 2025
8de09fc
TPC: change default max-delay to 1 for o2-tpc-calibrator-dedx
ehellbar Aug 7, 2025
c1576ad
DPL CDDB: hide private implementation of CCDBFetrcherHelper
ktf Aug 28, 2025
4d6b61e
Fix DCS object sspec for MFT noise calibration
Aug 27, 2025
e962d83
DPL Analysis: percolate DataOrigin so that we can use it for multiple…
ktf Aug 27, 2025
bd41c6a
Add missing includes
njacazio Aug 25, 2025
a4c0d4f
Fix codechecker error
davidrohr Aug 29, 2025
aee6ae7
Add includes
njacazio Aug 25, 2025
ac05dee
DPL: print error when exit transition timer expires
ehellbar Aug 29, 2025
3db6cca
GPU Workflow: Pop next tf from completion policy queue only when actu…
davidrohr Aug 29, 2025
6fd377b
DPL: initial metric to debug size of the histograms / objects being w…
ktf Aug 29, 2025
0574264
DPL: change exit transition timeout default on FLPs to 40 s (#14638)
ehellbar Aug 30, 2025
ef0de0f
DPL: fix for printing O2_SIGNPOST_END without start interval (#14637)
ehellbar Aug 30, 2025
dbd2625
Add to trackdata in residuals TOF time difference and t0 error
shahor02 Aug 29, 2025
17ae0d0
TOF matching should use the same FT0 int. tag as other global workflows
shahor02 Aug 31, 2025
6749a80
dpl-workflow.sh: modifying config/key defaults (ITS, MFT, MCH) for sy…
ehellbar Aug 26, 2025
c09477e
ITS: GPU: added launch bounds for ITS kernels, not fully optimised fo…
cima22 Sep 3, 2025
5f95c73
ITS: extend macros for pull distributions
f3sch Sep 1, 2025
f37a28b
GPU: TODO: TPCRawCluster needed in Base GPUReconstructionConvert
vikasssinghal Sep 2, 2025
7d68370
Fix EnumFlags compilation for large enums
aferrero2707 Sep 4, 2025
d7638de
Geo: Fix Run 4 barrel beam pipe section
f3sch Aug 28, 2025
98f5ae0
DPL Analysis: improve grouping performance further (#14600)
aalkin Sep 5, 2025
db05c58
Fix inconsistencies in the HelixHelper
shahor02 Sep 2, 2025
1cfbc1d
ITS: make CA tracker the default
f3sch Sep 4, 2025
c1cd2a6
With -condition-use-slice-for-prescaling <N> use TF slice instead of …
shahor02 Sep 4, 2025
642abba
Removed work-around in FindGeant4.cmake
ihrivnac Sep 2, 2025
1f95ef5
Remove old Jenkinsfile (#14642)
singiamtel Sep 9, 2025
767bdde
Merge branch 'dev' into dev-clean
mhemmer-cern Sep 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class CellLabel
/// \brief Constructor using gsl::span
/// \param labels list of mc labels
/// \param amplitudeFractions list of amplitude fractions
CellLabel(std::vector<int> labels, std::vector<float> amplitudeFractions);
CellLabel(gsl::span<const int> labels, gsl::span<const float> amplitudeFractions);

// ~CellLabel() = default;
// CellLabel(const CellLabel& clus) = default;
Expand Down Expand Up @@ -77,4 +77,4 @@ class CellLabel

} // namespace emcal
} // namespace o2
#endif // ALICEO2_EMCAL_CELLLABEL_H_
#endif // ALICEO2_EMCAL_CELLLABEL_H_
12 changes: 9 additions & 3 deletions DataFormats/Detectors/EMCAL/src/CellLabel.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,20 @@
#include "fairlogger/Logger.h"
#include <cstddef>
#include <cstdint>
#include <vector>
#include <gsl/span>
#include <vector>
#include <utility>

using namespace o2::emcal;

CellLabel::CellLabel(std::vector<int> labels, std::vector<float> amplitudeFractions) : mLabels(labels), mAmplitudeFraction(amplitudeFractions)
CellLabel::CellLabel(std::vector<int> labels, std::vector<float> amplitudeFractions) : mLabels(std::move(labels)), mAmplitudeFraction(std::move(amplitudeFractions))
{
if (labels.size() != amplitudeFractions.size()) {
LOG(error) << "Size of labels " << labels.size() << " does not match size of amplitude fraction " << amplitudeFractions.size() << " !";
}
}

CellLabel::CellLabel(gsl::span<const int> labels, gsl::span<const float> amplitudeFractions) : mLabels(labels.begin(), labels.end()), mAmplitudeFraction(amplitudeFractions.begin(), amplitudeFractions.end())
{
if (labels.size() != amplitudeFractions.size()) {
LOG(error) << "Size of labels " << labels.size() << " does not match size of amplitude fraction " << amplitudeFractions.size() << " !";
Expand All @@ -41,4 +47,4 @@ int32_t CellLabel::GetLeadingMCLabel() const
}
}
return mLabels[maxIndex];
}
}