Skip to content

Work around NodeJS bug involving path extensions #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvilk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Work around NodeJS bug involving path extensions #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ var spawn = require('child_process').spawn;
var fs = require('fs');
var version = JSON.parse(fs.readFileSync(__dirname + '/package.json', 'utf8')).version;
var verbose = process.env['npm_package_config_verbose'] != null ? process.env['npm_package_config_verbose'] === 'true' : false;
var isWindows = require('os').platform().indexOf('win') === 0;

console.log('[execsync v%s] Attempting to compile native extensions.', version);

var gyp = spawn('node-gyp', ['rebuild'], {cwd: __dirname});
// While node-gyp is runnable in Windows from the command line as `node-gyp`,
// it's actually defined in the file `node-gyp.cmd`.
// Relevant bug: https://github.com/joyent/node/issues/2318
var gyp = spawn(isWindows ? 'node-gyp.cmd' : 'node-gyp', ['rebuild'], {cwd: __dirname});
gyp.stdout.on('data', function(data) {
if (verbose) process.stdout.write(data);
});
Expand Down