Skip to content

Speed up at_addrs with a dict. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rainwoodman wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Speed up at_addrs with a dict. #38

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09cc5c0
Speed up at_addrs with a dict.
rainwoodman Jul 5, 2018
21c7cb7
flake
rainwoodman Jul 5, 2018
7f5e2e3
Ignore addresses not backed by objects.
rainwoodman Jul 9, 2018
775a796
lint
rainwoodman Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions objgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,9 +582,14 @@ def at_addrs(address_set):
.. versionadded:: 3.4
"""
res = []
for o in gc.get_objects():
if id(o) in address_set:
res.append(o)
id_to_obj = dict((id(o), o) for o in gc.get_objects())
Copy link

@klahnakoski klahnakoski Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest

id_to_obj = {id(o): o for o in gc.get_objects()}

Copy link
Owner

@mgedmin mgedmin Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


for i in address_set:
Copy link

@klahnakoski klahnakoski Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest change these lines to

return [
    id_to_obj[i] 
    for i in address_set
    if i in id_to_obj
]

Copy link
Owner

@mgedmin mgedmin Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except I'd put it all on a single line

if i not in id_to_obj: # ignore non-existing objects.
continue
o = id_to_obj[i]
res.append(o)

return res


Expand Down