Skip to content

Conversation

@mfranzke
Copy link
Owner

@mfranzke mfranzke commented Dec 7, 2025

Description

Added missing dependency. And remove previous approach for prettification again, as we seem to need to write a changelog-function on our own.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Testing

  • Tests pass locally
  • Added tests for new functionality
  • Updated existing tests
  • Manual testing completed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Browser Testing

If applicable, please test in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Performance Impact

If this change affects performance:

  • I have run performance benchmarks
  • Performance impact is documented
  • Performance regression is acceptable for the added functionality

Breaking Changes

If this introduces breaking changes, please describe:

Additional Notes

Any additional information that reviewers should know.

@mfranzke mfranzke self-assigned this Dec 7, 2025
Copilot AI review requested due to automatic review settings December 7, 2025 11:09
@mfranzke mfranzke added the enhancement New feature or request label Dec 7, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

⚠️ No Changeset found

Latest commit: 51b6dad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link

socket-security bot commented Dec 7, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​changesets/​changelog-github@​0.5.21001006893100

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing dependency issue by adding @changesets/changelog-github to the project's devDependencies. The package was already configured in .changeset/config.json but wasn't actually installed. Additionally, the PR removes the automatic prettier formatting of changelog files from the version script, as the team plans to implement a custom changelog formatting function in the future.

Key Changes

  • Added missing @changesets/changelog-github@0.5.2 dependency
  • Removed prettier formatting step from changeset:version script
  • Improved JSON formatting in .changeset/config.json for better readability

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Added @changesets/changelog-github to devDependencies and removed prettier formatting from the changeset:version script
.changeset/config.json Reformatted changelog configuration array for better readability (multi-line format)
pnpm-lock.yaml Auto-generated lockfile updates reflecting the new dependency and its transitive dependencies (dotenv, dataloader, node-fetch, etc.)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🚀 Performance Benchmark Results

Metric Value Status
Initialization Time 0.40ms
Avg Processing Time 0.2619ms
Total Processing Time (1000x) 261.90ms ℹ️

✅ All benchmarks passed!

@mfranzke mfranzke merged commit 46a237d into main Dec 7, 2025
25 checks passed
@mfranzke mfranzke deleted the refactor-changesets-added-missing-dependency branch December 7, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants