Skip to content

Conversation

@mfranzke
Copy link
Owner

@mfranzke mfranzke commented Dec 7, 2025

Description

Currently when we let changesets generate our CHANGELOG files, these wouldn't meet the prettier standards. So we introduce a prettier code formatting afterwards.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Testing

  • Tests pass locally
  • Added tests for new functionality
  • Updated existing tests
  • Manual testing completed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Browser Testing

If applicable, please test in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Performance Impact

If this change affects performance:

  • I have run performance benchmarks
  • Performance impact is documented
  • Performance regression is acceptable for the added functionality

Breaking Changes

If this introduces breaking changes, please describe:

Additional Notes

Any additional information that reviewers should know.

@mfranzke mfranzke self-assigned this Dec 7, 2025
Copilot AI review requested due to automatic review settings December 7, 2025 10:28
@mfranzke mfranzke added the enhancement New feature or request label Dec 7, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

⚠️ No Changeset found

Latest commit: b0d4273

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the changeset versioning workflow by automatically formatting CHANGELOG.md files with Prettier after they are generated by changesets. This ensures that generated changelogs conform to the project's code style standards without requiring manual formatting.

Key Changes

  • Added automatic Prettier formatting of CHANGELOG files to the changeset:version script

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🚀 Performance Benchmark Results

Metric Value Status
Initialization Time 0.30ms
Avg Processing Time 0.2632ms
Total Processing Time (1000x) 263.20ms ℹ️

✅ All benchmarks passed!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🚀 Performance Benchmark Results

Metric Value Status
Initialization Time 0.40ms
Avg Processing Time 0.2436ms
Total Processing Time (1000x) 243.60ms ℹ️

✅ All benchmarks passed!

@mfranzke mfranzke merged commit 249ab7a into main Dec 7, 2025
25 checks passed
@mfranzke mfranzke deleted the refactor-changesets-resilience-on-prettier-formatting branch December 7, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants