-
Notifications
You must be signed in to change notification settings - Fork 0
chore: compliance gaps, security, and quality improvements #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "npm" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||||
| name: "CodeQL" | ||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: [ "main" ] | ||||||
| pull_request: | ||||||
| branches: [ "main" ] | ||||||
| schedule: | ||||||
| - cron: '20 20 * * 4' | ||||||
|
|
||||||
| jobs: | ||||||
| analyze: | ||||||
| name: Analyze | ||||||
| runs-on: ubuntu-latest | ||||||
| permissions: | ||||||
| actions: read | ||||||
| contents: read | ||||||
| security-events: write | ||||||
|
|
||||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| language: [ 'javascript' ] | ||||||
|
||||||
| language: [ 'javascript' ] | |
| language: [ 'actions' ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"id":"uYIf5fCu","description":"Bring the repo into compliance with AGENTS.md and project standards","stage":"in-progress","createdAt":"2026-03-07T04:02:50.599Z","updatedAt":"2026-03-07T04:02:50.599Z"} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -38,7 +38,7 @@ Source: github:metyatech/agent-rules@HEAD/rules/global/agent-rules-composition.m | |||||
|
|
||||||
| Source: github:metyatech/agent-rules@HEAD/rules/global/autonomous-operations.md | ||||||
|
|
||||||
| # Autonomous operations | ||||||
| # Autonomous operations | ||||||
|
||||||
| # Autonomous operations | |
| # Autonomous operations |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,6 +24,15 @@ Returns APPROVE or FLAG with specific concerns. | |||||
| npx skills add metyatech/skill-user-proxy --yes --global | ||||||
| ``` | ||||||
|
|
||||||
| ## Testing and Examples | ||||||
|
|
||||||
| See the [tests/](tests/) directory for examples of: | ||||||
|
|
||||||
| - **Good plans**: That meet all criteria and are APPROVED. | ||||||
| - **Bad plans**: That fail criteria (missing verification, known error patterns) and are FLAGed. | ||||||
|
||||||
| - **Bad plans**: That fail criteria (missing verification, known error patterns) and are FLAGed. | |
| - **Bad plans**: That fail criteria (missing verification, known error patterns) and are FLAGGED. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| # Skill tests and examples | ||||||
|
|
||||||
| This directory contains examples of work plans and their review results using `skill-user-proxy`. | ||||||
|
|
||||||
| ## Structure | ||||||
|
|
||||||
| - `examples/good-plan.md`: A plan that meets all criteria and is APPROVED. | ||||||
| - `examples/bad-plan.md`: A plan that fails criteria (missing verification, known error patterns) and is FLAGed. | ||||||
|
||||||
| - `examples/bad-plan.md`: A plan that fails criteria (missing verification, known error patterns) and is FLAGed. | |
| - `examples/bad-plan.md`: A plan that fails criteria (missing verification, known error patterns) and is FLAGGED. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Example bad plan | ||
|
|
||
| ## Objective | ||
|
|
||
| Fix a bug in `index.js`. | ||
|
|
||
| ## Plan | ||
|
|
||
| 1. Read `index.js`. | ||
| 2. Edit `index.js` to fix the bug. | ||
| 3. Report completion. | ||
|
|
||
| ## Review Results (skill-user-proxy) | ||
|
|
||
| - **Completeness**: No. Missing verification steps (tests/manual check). | ||
| - **Thoroughness**: Surface-level plan. | ||
| - **Known error patterns**: | ||
| - **Shallow analysis**: Declaring work "complete" without evidence. | ||
| - **Missing post-deployment**: If `index.js` is part of a globally linked package, it needs a rebuild/restart check. | ||
|
|
||
| **Decision**: FLAG | ||
|
|
||
| - **Concern**: The plan lacks any verification steps (e.g., running tests or manual verification) to ensure the bug is actually fixed. | ||
| - **Concern**: No mention of post-deployment steps if this is a globally linked tool. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Example good plan | ||
|
|
||
| ## Objective | ||
|
|
||
| Update the README with installation instructions. | ||
|
|
||
| ## Plan | ||
|
|
||
| 1. Read `README.md`. | ||
| 2. Update `README.md` with `npx skills add metyatech/skill-user-proxy` command. | ||
| 3. Verify the content of `README.md`. | ||
|
|
||
| ## Acceptance Criteria | ||
|
|
||
| - README.md has the installation section. (PASS) | ||
|
|
||
| ## Review Results (skill-user-proxy) | ||
|
|
||
| - **Completeness**: Yes. Covers reading, updating, and verifying. | ||
| - **Thoroughness**: Yes. AC is binary and testable. | ||
| - **Known error patterns**: None. | ||
|
|
||
| **Decision**: APPROVE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot is configured for the
npmecosystem in/, but the repository doesn't currently have apackage.json/lockfile. This will cause Dependabot runs to error. Either remove the npm entry, or add the expected npm manifests so Dependabot can operate.