Skip to content

Add test data for quantile mapping acceptance tests #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwhitemet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add test data for quantile mapping acceptance tests #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b204c62
Add test data for quantile mapping acceptance tests
maxwhitemet Dec 8, 2025
b800d28
Update tests to reflect plugin changes following review
maxwhitemet Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/quantile-mapping/basic/kgo.nc
View file
Open in desktop
Binary file not shown.
Binary file added data/quantile-mapping/forecast.nc
View file
Open in desktop
Copy link
Contributor

@gavinevans gavinevans Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These acceptance test inputs are overly small and look like they're just the same as the unit test data. The aim with the acceptance test inputs is to provide something a bit more realistic. A larger domain (50x50 or 100x100) would be helpful to understand the behaviour. It would be helpful to add visualisations of all the inputs and kgos to the ticket.

The current data looks like as below. In this example, it looks like the forecast to larger than the reference so quantile mapping is scaling down the values.
image

Binary file not shown.
Binary file added data/quantile-mapping/reference.nc
View file
Open in desktop
Binary file not shown.
Binary file added data/quantile-mapping/with_preservation_threshold/kgo.nc
View file
Open in desktop
Binary file not shown.