Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
d5518c2
Pure-torch version implemented by chatty and claude
GardevoirX May 4, 2026
aa8a0d1
Formatting
GardevoirX May 4, 2026
79920c8
A little bit more comments
GardevoirX May 4, 2026
2802dc4
Remove a over-defensive patch
GardevoirX May 4, 2026
cc2bad4
Formatting
GardevoirX May 4, 2026
f3c328a
Update python/metatomic_torch/metatomic/torch/dftd3.py
GardevoirX May 6, 2026
2fc016f
Update python/metatomic_torch/metatomic/torch/dftd3.py
GardevoirX May 6, 2026
b857815
Updates according to reviewer's comments
GardevoirX May 6, 2026
c3bf55c
Formatting
GardevoirX May 6, 2026
8824c8a
Update the unit conversion logic
GardevoirX May 6, 2026
5d0da6c
Allow D3 wrapper to load parameters from local file automatically, an…
GardevoirX May 6, 2026
6b1fcda
Formatting
GardevoirX May 6, 2026
036bdb6
Support non-conservative cases
GardevoirX May 7, 2026
152e2d3
Formatting
GardevoirX May 7, 2026
10e46b2
Enable `select_atoms`
GardevoirX May 7, 2026
d52e4f5
Improve the error and warning strings
GardevoirX May 7, 2026
3455005
Sophisticated treatments to non conservative variants
GardevoirX May 7, 2026
e9020e3
Removed the logic of auto-correcting non-conservative outputs, and ad…
GardevoirX May 8, 2026
0a1a9c3
Removed `MetatomicCalculator` from the tests
GardevoirX May 8, 2026
bc07213
Allowed users to disable D3 corrections for certain types of atoms
GardevoirX May 8, 2026
f817ca7
Simplified the test codes and improved the naming
GardevoirX May 12, 2026
f4b4063
Fromatting
GardevoirX May 12, 2026
63986b3
Updated tests again
GardevoirX May 13, 2026
b63ae63
Apply suggestions from code review
GardevoirX May 20, 2026
5965ab3
Update to the parameter used by `simple-dftd3`
GardevoirX May 20, 2026
a5d3115
Formatting
GardevoirX May 20, 2026
1e645ff
Directly calculate force/stress corrections for non-conservative outputs
GardevoirX May 22, 2026
12e9e38
Formatting and removed an unused method
GardevoirX May 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/metatomic_ase/src/metatomic_ase/_neighbors.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def _compute_requested_neighbors_nvalchemi(systems, requested_options):
options.engine_cutoff("angstrom"),
cell=system.cell,
pbc=system.pbc,
max_neighbors=16384,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? and why this value?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing on mad dataset, there were some errors related to the number of neighbors. Chatty lifted this value twice to get everything passed. It chose this value because it satisfies 2^n, I think. If we are interested in which structure led to the error, I can do more tests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! I think we could set this to a similar value as the one we use in vesin, which is based on the cutoff + number of atoms.

return_neighbor_list=True,
)
D = (
Expand Down
2 changes: 2 additions & 0 deletions python/metatomic_torch/MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ include git_version_info
include metatomic-torch-*.tar.gz

recursive-include build-backend *.py

recursive-include metatomic/torch/data *.npz
Binary file not shown.
1,094 changes: 1,094 additions & 0 deletions python/metatomic_torch/metatomic/torch/dftd3.py

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions python/metatomic_torch/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ filterwarnings = [
"ignore:`torch.jit.script` is deprecated. Please switch to `torch.compile` or `torch.export`:DeprecationWarning",
"ignore:`torch.jit.save` is deprecated. Please switch to `torch.export`:DeprecationWarning",
"ignore:`torch.jit.load` is deprecated. Please switch to `torch.export`:DeprecationWarning",
"ignore:`torch.jit.script_method` is not supported in Python 3.14+:DeprecationWarning",
"ignore:`torch.jit.script` is not supported in Python 3.14+:DeprecationWarning",
"ignore:`torch.jit.save` is not supported in Python 3.14+:DeprecationWarning",
"ignore:`torch.jit.load` is not supported in Python 3.14+:DeprecationWarning",
Expand Down
3 changes: 2 additions & 1 deletion python/metatomic_torch/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ def create_version_number(version):
"metatomic/torch/torch-*/bin/*",
"metatomic/torch/torch-*/lib/*",
"metatomic/torch/torch-*/include/*",
]
"metatomic/torch/data/*",
],
},
)
Loading
Loading