-
Notifications
You must be signed in to change notification settings - Fork 7
DFT-D3 wrapper #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GardevoirX
wants to merge
28
commits into
metatensor:main
Choose a base branch
from
GardevoirX:DFT-D3-pytorch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DFT-D3 wrapper #219
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d5518c2
Pure-torch version implemented by chatty and claude
GardevoirX aa8a0d1
Formatting
GardevoirX 79920c8
A little bit more comments
GardevoirX 2802dc4
Remove a over-defensive patch
GardevoirX cc2bad4
Formatting
GardevoirX f3c328a
Update python/metatomic_torch/metatomic/torch/dftd3.py
GardevoirX 2fc016f
Update python/metatomic_torch/metatomic/torch/dftd3.py
GardevoirX b857815
Updates according to reviewer's comments
GardevoirX c3bf55c
Formatting
GardevoirX 8824c8a
Update the unit conversion logic
GardevoirX 5d0da6c
Allow D3 wrapper to load parameters from local file automatically, an…
GardevoirX 6b1fcda
Formatting
GardevoirX 036bdb6
Support non-conservative cases
GardevoirX 152e2d3
Formatting
GardevoirX 10e46b2
Enable `select_atoms`
GardevoirX d52e4f5
Improve the error and warning strings
GardevoirX 3455005
Sophisticated treatments to non conservative variants
GardevoirX e9020e3
Removed the logic of auto-correcting non-conservative outputs, and ad…
GardevoirX 0a1a9c3
Removed `MetatomicCalculator` from the tests
GardevoirX bc07213
Allowed users to disable D3 corrections for certain types of atoms
GardevoirX f817ca7
Simplified the test codes and improved the naming
GardevoirX f4b4063
Fromatting
GardevoirX 63986b3
Updated tests again
GardevoirX b63ae63
Apply suggestions from code review
GardevoirX 5965ab3
Update to the parameter used by `simple-dftd3`
GardevoirX a5d3115
Formatting
GardevoirX 1e645ff
Directly calculate force/stress corrections for non-conservative outputs
GardevoirX 12e9e38
Formatting and removed an unused method
GardevoirX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required? and why this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing on mad dataset, there were some errors related to the number of neighbors. Chatty lifted this value twice to get everything passed. It chose this value because it satisfies 2^n, I think. If we are interested in which structure led to the error, I can do more tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please! I think we could set this to a similar value as the one we use in vesin, which is based on the cutoff + number of atoms.