Remove Saxon and xmlresolver dependencies#215
Conversation
📝 WalkthroughWalkthroughThree test YAML resource files were restructured to reorganize control-objective-selections and control-selections blocks. The changes reorder these sections and modify their nesting levels while preserving all objective IDs and control IDs across the files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom Pre-merge Checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Comment |
Fix ambiguous YAML indentation in assessment-results test files that caused parsing errors with stricter metaschema-java validation. The control-selections and control-objective-selections elements now have proper indentation as siblings under reviewed-controls.
71c30c4 to
5dea963
Compare
edc30b7
into
metaschema-framework:develop
Summary
TransformerFactoryImplwith standard JavaTransformerFactoryinPrettyPrinterfor XML indentationxmlresolverdependencies from pom.xmlThese dependencies were removed from metaschema-java in metaschema-framework/metaschema-java#607.
Test plan
PrettyPrinter.prettyPrintXml()still produces properly indented outputSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.