Skip to content

Detect manufacturer with ipxe script #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
majst01 wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Detect manufacturer with ipxe script #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cad5eec
Detect manufacturer with ipxe script
majst01 Dec 5, 2025
712696e
Use manufacturer variable directly
simcod Dec 5, 2025
d5ee693
Make ipxe file visible
simcod Dec 5, 2025
abc21d7
Set manufacturer console in go generated ipxe
simcod Dec 5, 2025
373abb6
Set variables first and adapt tests
simcod Dec 5, 2025
3ad4886
Check with ttyS0
simcod Dec 5, 2025
b07c59c
test
simcod Dec 5, 2025
a02ea07
Fix tests
simcod Dec 5, 2025
32df583
Write ttyS0
simcod Dec 5, 2025
5447bd7
Check for manufacturer now
simcod Dec 5, 2025
2e609bd
Fix tests
simcod Dec 5, 2025
36b62ce
Use different syntax
simcod Dec 5, 2025
87e378f
Adapt tests
simcod Dec 5, 2025
1e9034a
Check for supermicro
simcod Dec 5, 2025
4f97277
Add default case
simcod Dec 5, 2025
22d8d2c
Use ttyS1 as default
simcod Dec 5, 2025
0d635a1
Test dell with whitespace
simcod Dec 5, 2025
a1830a9
Check for Giga Computing manufacturer
simcod Dec 8, 2025
2d36ce9
Check for console variable
simcod Dec 8, 2025
97e2d6f
Remove console variable again
simcod Dec 8, 2025
bbcc0d0
Put manufacturer distinction into ipxe script
simcod Dec 15, 2025
7b077e8
Check for console
simcod Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pixiecore/boot.ipxe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ set user-class pixiecore

echo metal-stack pixie

echo Manufacturer: ${manufacturer}

# Detect serial console based on manufacturer.
# Implicitly ttyS1 is used as console for Supermicro.

set console ttyS1
set sp:hex 20 && set sp ${sp:string}
iseq ${manufacturer} Dell${sp}Inc. && set console ttyS0 ||
iseq ${manufacturer} Giga${sp}Computing && set console ttyS0 ||

# Try to get a filename from ProxyDHCP, retrying a couple of times if
# we fail.
:loop
Expand Down
2 changes: 2 additions & 0 deletions pixiecore/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ func ipxeScript(mach Machine, spec *Spec, serverHost string) ([]byte, error) {
urlTemplate := fmt.Sprintf("http://%s/_/file?name=%%s&type=%%s&mac=%%s", serverHost)
var b bytes.Buffer
b.WriteString("#!ipxe\n")
b.WriteString("isset ${console} || set console ttyS1\n")
u := fmt.Sprintf(urlTemplate, url.QueryEscape(string(spec.Kernel)), "kernel", url.QueryEscape(mach.MAC.String()))
fmt.Fprintf(&b, "kernel --name kernel %s\n", u)
for i, initrd := range spec.Initrd {
Expand All @@ -218,6 +219,7 @@ func ipxeScript(mach Machine, spec *Spec, serverHost string) ([]byte, error) {
if err != nil {
return nil, fmt.Errorf("expanding cmdline %q: %w", spec.Cmdline, err)
}
b.WriteString("console=${console},115200n8 ")
Copy link
Contributor Author

@majst01 majst01 Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only add this console line if ${console} is not empty string.

But i don't now how this is possible with ipxe scripting

Copy link
Contributor Author

@majst01 majst01 Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually with:

b.WriteString("isset ${console} && console=${console},115200n8 ||")

Copy link
Contributor

@simcod simcod Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the console parameter in the boot.ipxe script by default to ttyS1. The variable should be passed down, where we construct the ipxe script. So I assume it should not be an empty string.

However, we could add something like this upfront:

...
b.WriteString("isset ${console} || set console ttyS1")
b.WriteString("console=${console},115200n8 ")
...

b.WriteString(cmdline)
b.WriteByte('\n')

Expand Down
6 changes: 4 additions & 2 deletions pixiecore/http_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,13 @@ func TestIpxe(t *testing.T) {
}

expected := `#!ipxe
isset ${console} || set console ttyS1
kernel --name kernel http://localhost:1234/_/file?name=k-01%3A02%3A03%3A04%3A05%3A06-0&type=kernel&mac=01%3A02%3A03%3A04%3A05%3A06
initrd --name initrd0 http://localhost:1234/_/file?name=i1-01%3A02%3A03%3A04%3A05%3A06-0&type=initrd&mac=01%3A02%3A03%3A04%3A05%3A06
initrd --name initrd1 http://localhost:1234/_/file?name=i2-01%3A02%3A03%3A04%3A05%3A06-0&type=initrd&mac=01%3A02%3A03%3A04%3A05%3A06
imgfetch --name ready http://localhost:1234/_/booting?mac=01%3A02%3A03%3A04%3A05%3A06 ||
imgfree ready ||
boot kernel initrd=initrd0 initrd=initrd1 thing=http://localhost:1234/_/file?name=f-01%3A02%3A03%3A04%3A05%3A06-0 foo=bar
boot kernel initrd=initrd0 initrd=initrd1 console=${console},115200n8 thing=http://localhost:1234/_/file?name=f-01%3A02%3A03%3A04%3A05%3A06-0 foo=bar
`
if rr.Body.String() != expected {
t.Fatalf("Wrong iPXE script\nwant: %s\ngot: %s", expected, rr.Body.String())
Expand All @@ -91,12 +92,13 @@ boot kernel initrd=initrd0 initrd=initrd1 thing=http://localhost:1234/_/file?nam
}

expected = `#!ipxe
isset ${console} || set console ttyS1
kernel --name kernel http://localhost:1234/_/file?name=k-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=kernel&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe
initrd --name initrd0 http://localhost:1234/_/file?name=i1-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=initrd&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe
initrd --name initrd1 http://localhost:1234/_/file?name=i2-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=initrd&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe
imgfetch --name ready http://localhost:1234/_/booting?mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe ||
imgfree ready ||
boot kernel initrd=initrd0 initrd=initrd1 thing=http://localhost:1234/_/file?name=f-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1 foo=bar
boot kernel initrd=initrd0 initrd=initrd1 console=${console},115200n8 thing=http://localhost:1234/_/file?name=f-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1 foo=bar
`
if rr.Body.String() != expected {
t.Fatalf("Wrong iPXE script\nwant: %s\ngot: %s", expected, rr.Body.String())
Expand Down