Introduce namespaces for memberships.#132
Merged
Conversation
c02760b to
10a34a7
Compare
Contributor
Author
|
I need to provide more tests for this. |
majst01
reviewed
Sep 10, 2025
majst01
reviewed
Sep 10, 2025
majst01
reviewed
Sep 11, 2025
Contributor
Author
|
So, I tested this out in multiple places now. First, there are some fresh unit tests for this functionality. Second, I built the existing repositories that use memberships (metal-apiserver and metalstack.cloud api-server) with this pull request and ensured that all tests are passing. Third, I started this PR in the mini-lab and run it along with the metal-apiserver + the metalstack.cloud api-server. I ensured project invitations are now namespaced and that both servers do not see each other's memberships. The projects and tenants can be seen in both APIs of course by design. Here are some extracts: |
majst01
approved these changes
Sep 15, 2025
majst01
pushed a commit
that referenced
this pull request
Oct 6, 2025
* Introduce namespaces for memberships. (#132) * Merge main into connect branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #130.