-
Notifications
You must be signed in to change notification settings - Fork 27
[AutoAgent] Add option to ignore router cache #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kaiming-cheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, leave one review on the _load_router_cache call
| } | ||
| _save_router_cache(cache) | ||
| if self.use_router_cache: | ||
| cache[code_hash] = info.get("parsed") or { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
router-emitted config.llm_models / config.ka_model can be non-configured/inaccessible, gets cached verbatim, and later runs apply it unvalidated. Please consider validating/intersecting against the local registry (utils/providers/available_models.py) + provider availability before (a) applying and/or (b) writing to cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I have a local fix I'll push in a separate PR since there's actually some other bugs that get tackled over there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't always want to use the cached routing config. This adds an option to turn off the cache
python -m Fuser.auto_agent --problem /home/jackkhuu/KernelBench/KernelBench/level3/33_VanillaRNN.pypython -m Fuser.auto_agent --problem /home/jackkhuu/KernelBench/KernelBench/level3/33_VanillaRNN.py --no-router-cache