Skip to content

Conversation

@mogres
Copy link
Collaborator

@mogres mogres commented Nov 6, 2025

Problem

Closes #427 #396

Solution

Added options to allow zero decay length in gradients. Also added test options in recipe.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

pack -r cellpack/tests/recipes/v2/test_gradient.json -c cellpack/tests/packing-configs/test_grid_plot_config.json

Check the weights of the zero decay gradient in simularium.

Note

Spheres will still be packed with radial gradient. To pack using the zero decay gradient, edit the recipe.

Screenshots (optional):

image

@mogres mogres requested review from meganrm and rugeli November 6, 2025 23:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

Copy link
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes with and without directly editing the test recipe, both worked fine, and the results looked good to me!

@mogres mogres merged commit ee68291 into main Jan 2, 2026
10 checks passed
@mogres mogres deleted the fix/gradient_updates branch January 2, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle 0 decay_length in gradients

4 participants