abseil-cpp: enable tests, add tracing.cc to base sources #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache-hb
force-pushed
the
abseil-cpp
branch
9 times, most recently
from
e405feb to
dca64b2
Compare
neheb
reviewed
Oct 18, 2025
neheb
reviewed
Oct 18, 2025
apache-hb
force-pushed
the
abseil-cpp
branch
2 times, most recently
from
4b22b41 to
ed7bd44
Compare
Member
|
Will merge in a week if there are no objections. |
bonzini
reviewed
Dec 24, 2025
|
Looks good, with just an aesthetic comment that you can disregard too. |
Member
|
clang-cl arm64 job failure seems to be related. MSYS2 CLANGARM64 job failure needs investigating |
apache-hb
force-pushed
the
abseil-cpp
branch
from
ae74cd5 to
977fbd1
Compare
Contributor
Author
|
Seems the msys2 failure is due to msys2/MSYS2-packages#2058, I would guess the msys2/setup-msys2 action needs to updated to resolve that failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
tracing.cctoabsl_base_sources, and adds tests for base, numeric, hash, crc32, container, and logging to try and catch any other missing sources.