vo-aacenc.wrap: Fix building as a subproject #2425
Conversation
|
CI fails due to mesonbuild/meson#15062. Can be re-run when 1.9.2 or newer versions are released. |
Due to the header layout, this was previously only usable after installation into a prefix.
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -0,0 +1,503 @@ | |||
| GNU LESSER GENERAL PUBLIC LICENSE | |||
There was a problem hiding this comment.
Wait, where did this come from? This PR makes a fairly small change to the wrap, you aren't the original wrap author, and the upstream project is Apache 2.0, so it seems strange that the PR wants to relicense the wrap to LGPLv2.1.
There was a problem hiding this comment.
You know what, that's a great question. I have no idea how that change got in. I don't recall adding it.
There was a problem hiding this comment.
Ah, it got memory-holed because it was so long ago. LGPL-2.1 is the license of makedef.py. This change is of course wrong, I will fix it.
There was a problem hiding this comment.
Oh okay, I understand the situation now. LICENSE.build should indeed have the MIT license, but also the LGPL license with some text saying that it applies to makedef.py.
nirbheek
force-pushed
the
voaacenc
branch
2 times, most recently
from
113a8eb to
4864a2d
Compare
AssertionError: Found files subprojects/packagefiles/vo-aacenc/meson/makedef.py with license headers in a project without a LICENSE.build. The LICENSE.build file in the patch ZIP defaults to MIT unless the patch directory has its own LICENSE.build, which should state the license for the wrap's build files.
On armv7, we use a feature introduced in '1.2.0': compiler.compiles with file created at setup time. It was broken and either errored or returned false.
|
Will merge in a week if there are no objections. |
|
Could you add a comment above LGTM aside from those two comments. |
3 participants
Due to the header layout, this was previously only usable after installation into a prefix.