Add very simple shell completion using argcomplete#721
Merged
ianmcorvidae merged 2 commits intomeshtastic:masterfrom Dec 22, 2024
Merged
Add very simple shell completion using argcomplete#721ianmcorvidae merged 2 commits intomeshtastic:masterfrom
ianmcorvidae merged 2 commits intomeshtastic:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 60.99% 61.01% +0.02%
==========================================
Files 24 24
Lines 3899 3907 +8
==========================================
+ Hits 2378 2384 +6
- Misses 1521 1523 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640 in a rudimentary sort of fashion.
This could probably be improved upon by way of the process shown in the argcomplete docs -- but, it may also be the kind of thing that would depend on local persistence to be very efficient. This does at least add basic completion, which can be enabled with:
eval "$(register-python-argcomplete meshtastic)"(which can be put into a bashrc or similar). I'm unclear if argcomplete's support for global completion will work at present.