Update CLI command parameters for bridge source#2534
Open
khagele wants to merge 1 commit into
Open
Conversation
|
The change is correct, the set command already accepts Adding to this, the get/query command still returns the old names:
sprintf(reply, "> %s", _prefs->bridge_pkt_src ? "logRx" : "logTx");This should be changed to: sprintf(reply, "> %s", _prefs->bridge_pkt_src ? "rx" : "tx");Without this fix, a user running Optionally, these comments could also be updated for consistency:
But logRx and logTx are used in lots of other parts of the code so maybe it would make more sense to change it to accept both tx/rx and logTx/logRx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.