feat: Enable GPS on RAK 1W kit#2401
Merged
Merged
Conversation
Member
|
@liamcottle can be safely merged |
Member
|
Thanks all, I tried to find my spare RAK12500 gps module to test this on the 1W RAK units I have, but couldn't find it. Will take you word for it :) |
Merged
Member
|
seems that this PR broke the rak3401 and needs to be reverted. @446564 we should never just merge without testing and just take a word of the author. |
recrof
added a commit
to recrof/MeshCore
that referenced
this pull request
May 12, 2026
reverted changes to RAK_BOARD and PIN_GPS_EN. setting `RAK_BOARD` would cause radio to stop working and end with RadioLib error -707
oltaco
added a commit
that referenced
this pull request
May 12, 2026
revert: "feat: Enable GPS on RAK 1W kit" (#2401)
Member
|
I added a comment about what I think the issue might be. #2536 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables GPS on the RAK 1W Kit (RAK3401 + RAK13302) using the RAK12500 GPS module in slot A
The RAK12501 is not compatible at all from testing, and the RAK12500 is only compatible in slot A, not slot D