fix(bme680): fixed bme680 loss of precision int math error in pressure and altitude measurements#2149
Open
NickDunklee wants to merge 1 commit intomeshcore-dev:devfrom
Open
Conversation
NickDunklee
force-pushed
the
fix-bme680-pressure-altitude
branch
2 times, most recently
from
b5feb58 to
1c14441
Compare
…asurements BME680.pressure / 100 was integer division before being passed onward resulting in loss of sensor resoluiton for both altitude and pressure changes. - Changed to float math to fix the value only moving in 1hPa steps - Pressure/altitude should no longer appear "stuck" waiting to jump the next 1hPa change - Tested on RAK19003+BME680 It looks like BME280, BMP280, etc. should not be affected as their readPressure() is a float. BMP085 may have a similar problem, but I do not have one to test with.
NickDunklee
force-pushed
the
fix-bme680-pressure-altitude
branch
from
1c14441 to
96f8786
Compare
Author
Left side of graph was before change, right side after. Updated this comment with a better graph. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BME680.pressure / 100 was integer division before being passed onward resulting in loss of sensor resoluiton for both altitude and pressure changes.
It looks like BME280, BMP280, etc. should not be affected as their readPressure() is a float. BMP085 may have a similar problem, but I do not have one to test with.