Fix typo for ThinkNode M5 room server environment#2121
Merged
fdlamotte merged 1 commit intomeshcore-dev:devfrom Mar 25, 2026
Merged
Fix typo for ThinkNode M5 room server environment#2121fdlamotte merged 1 commit intomeshcore-dev:devfrom
fdlamotte merged 1 commit intomeshcore-dev:devfrom
Conversation
Merged
Collaborator
|
Thanks for your PR, can you please target the dev branch instead of main ;) |
robekl
added a commit
to robekl/MeshCore
that referenced
this pull request
Mar 23, 2026
Reimplements meshcore-dev/MeshCore PR meshcore-dev#2121 on top of 467959c for the 1.14.1 maintenance branch. References: PR: meshcore-dev#2121 PlatformIO extends option: https://docs.platformio.org/en/latest/projectconf/sections/env/options/advanced/extends.html Rationale: The ThinkNode_M5_room_server environment extends a misspelled base environment name in the 1.14.1 release commit. That typo prevents the environment from inheriting the intended settings. This backport is a one-line configuration correction with no runtime impact beyond making the environment resolve as originally intended, which makes it an easy and low-risk maintenance fix.
Author
|
@fdlamotte Do you mind having a look again at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.