Skip to content

Fix LED polarity on Thinknode M1, and align target configuration with datasheet #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobmn wants to merge 2 commits into
base: dev
Choose a base branch
from
+22 −22
Open

Fix LED polarity on Thinknode M1, and align target configuration with datasheet #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3448ee3
Update variant.h
jakobmn Mar 20, 2026
91d0ed1
cleanup and align with datasheet
jakobmn Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion variants/thinknode_m1/ThinkNodeM1Board.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ void ThinkNodeM1Board::begin() {

#ifdef P_LORA_TX_LED
pinMode(P_LORA_TX_LED, OUTPUT);
digitalWrite(P_LORA_TX_LED, LOW);
digitalWrite(P_LORA_TX_LED, !LED_STATE_ON);
#endif

pinMode(SX126X_POWER_EN, OUTPUT);
Expand Down
6 changes: 3 additions & 3 deletions variants/thinknode_m1/ThinkNodeM1Board.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ class ThinkNodeM1Board : public NRF52Board {

#if defined(P_LORA_TX_LED)
void onBeforeTransmit() override {
digitalWrite(P_LORA_TX_LED, HIGH); // turn TX LED on
digitalWrite(P_LORA_TX_LED, LED_STATE_ON); // turn TX LED on
}
void onAfterTransmit() override {
digitalWrite(P_LORA_TX_LED, LOW); // turn TX LED off
digitalWrite(P_LORA_TX_LED, !LED_STATE_ON); // turn TX LED off
}
#endif

Expand All @@ -36,7 +36,7 @@ class ThinkNodeM1Board : public NRF52Board {

// turn off all leds, sd_power_system_off will not do this for us
#ifdef P_LORA_TX_LED
digitalWrite(P_LORA_TX_LED, LOW);
digitalWrite(P_LORA_TX_LED, !LED_STATE_ON);
#endif

// power off board
Expand Down
4 changes: 1 addition & 3 deletions variants/thinknode_m1/variant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ void initVariant() {
pinMode(PIN_BUTTON1, INPUT_PULLUP);
pinMode(PIN_BUTTON2, INPUT_PULLUP);

pinMode(LED_RED, OUTPUT);
pinMode(LED_GREEN, OUTPUT);
pinMode(LED_RED, OUTPUT);
pinMode(LED_BLUE, OUTPUT);
digitalWrite(LED_BLUE, HIGH);

pinMode(PIN_TXCO, OUTPUT);
digitalWrite(PIN_TXCO, HIGH);
Expand Down
32 changes: 17 additions & 15 deletions variants/thinknode_m1/variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,21 @@
////////////////////////////////////////////////////////////////////////////////
// Builtin LEDs

#define LED_RED (38)
#define LED_GREEN (36)
#define LED_BLUE (14)

#define PIN_STATUS_LED LED_GREEN
#define LED_BUILTIN LED_GREEN
#define LED_RED (36)
#define LED_GREEN (-1) // No green LED on this target
#if defined(P_LORA_TX_LED) && P_LORA_TX_LED == 13
// When blue LED is used to indicate Lora TX,
// don't use it to indicate bluetooth connection state
#define LED_BLUE (-1)
#else
#define LED_BLUE (13)
#endif

#define PIN_STATUS_LED LED_RED
#define LED_BUILTIN LED_RED
#define PIN_LED LED_BUILTIN
#define LED_PIN LED_BUILTIN
#define LED_STATE_ON LOW

#define PIN_NEOPIXEL (14)
#define NEOPIXEL_NUM (2)
#define LED_STATE_ON HIGH

////////////////////////////////////////////////////////////////////////////////
// Builtin buttons
Expand All @@ -81,7 +84,7 @@
#define BUTTON_PIN PIN_BUTTON1
#define PIN_USER_BTN BUTTON_PIN

#define PIN_BUTTON2 (11)
#define PIN_BUTTON2 (39)
#define BUTTON_PIN2 PIN_BUTTON2

#define EXTERNAL_FLASH_DEVICES MX25R1635F
Expand All @@ -101,7 +104,7 @@
////////////////////////////////////////////////////////////////////////////////
// SPI1

#define PIN_SPI1_MISO (38)
#define PIN_SPI1_MISO (-1) // Not connected on this target
#define PIN_SPI1_MOSI (29)
#define PIN_SPI1_SCK (31)

Expand All @@ -122,7 +125,7 @@ extern const int SCK;
////////////////////////////////////////////////////////////////////////////////
// Display

#define DISP_MISO (38)
#define DISP_MISO (-1) // Not connected on this target
#define DISP_MOSI (29)
#define DISP_SCLK (31)
#define DISP_CS (30)
Expand All @@ -136,8 +139,7 @@ extern const int SCK;

#define PIN_GPS_RX (40)
#define PIN_GPS_TX (41)
#define GPS_EN (34)
#define GPS_EN PIN_GPS_STANDBY // Datasheet lists only STANDBY
#define PIN_GPS_RESET (37)
#define PIN_GPS_PPS (36)
#define PIN_GPS_STANDBY (34)
#define PIN_GPS_SWITCH (33)