Fix color_patches SolaraViz portrayal + update README#346
Open
Nandha-kumar-S wants to merge 3 commits intomesa:mainfrom
Open
Fix color_patches SolaraViz portrayal + update README#346Nandha-kumar-S wants to merge 3 commits intomesa:mainfrom
Nandha-kumar-S wants to merge 3 commits intomesa:mainfrom
Conversation
Author
|
hi @EwoutH Can you review this PR please? as this example's readme.md may mislead the users who try to run this model. I know that maintainers are busy, but hoping for a review when you get time :) |
Member
|
Thanks @Nandha-kumar-S! This is definitely overdue. Could you please fix the parameters (heigh and width) they do not show up in the interface. If you have time could you also clean up some of the outdated comments like the line 66 in |
Author
|
hi @tpike3 , i have updated the changes as requested. Please review them. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
color_patchesexample to run with Mesa 3.x SolaraViz and updtaed the README run instructions.Motive
The README referenced the legacy
mesa runserverflow, and the Solara app portrayal used CanvasGrid-style keys that are ignored in Mesa 3.x.Implementation
color,size).solara run app.pyand corrected the listed files.Usage Examples