Fix remoteName() to prefer origin remote#154
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
When a repo has multiple remotes, git remote lists them alphabetically. remoteName() took the first one, which could be a non-primary remote (e.g. 'launchpad' before 'origin'). This caused deploy:push to update GitHub variables on the wrong repository. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Git::remoteName()picked the first remote alphabetically fromgit remote, which could be a non-primary remote (e.g.launchpadbeforeorigin)deploy:pushto update GitHub variables on the wrong repository — variable was set onmerchantprotocol/launchpadinstead ofdataripple-org/ghostagentoriginwhen it exists, falling back to the first remote otherwiseTest plan
protocol deploy:push v0.1.8on a repo with multiple remotes (launchpad+origin) — correctly targetsorigin🤖 Generated with Claude Code