Skip to content

Fix remoteName() to prefer origin remote#154

Merged
jonathonbyrdziak merged 1 commit intomasterfrom
fix/git-remote-name-origin-preference
Mar 26, 2026
Merged

Fix remoteName() to prefer origin remote#154
jonathonbyrdziak merged 1 commit intomasterfrom
fix/git-remote-name-origin-preference

Conversation

@jonathonbyrdziak
Copy link
Copy Markdown
Contributor

Summary

  • Git::remoteName() picked the first remote alphabetically from git remote, which could be a non-primary remote (e.g. launchpad before origin)
  • This caused deploy:push to update GitHub variables on the wrong repository — variable was set on merchantprotocol/launchpad instead of dataripple-org/ghostagent
  • Now prefers origin when it exists, falling back to the first remote otherwise

Test plan

  • Verified protocol deploy:push v0.1.8 on a repo with multiple remotes (launchpad + origin) — correctly targets origin
  • Verify single-remote repos still work as before

🤖 Generated with Claude Code

When a repo has multiple remotes, git remote lists them alphabetically.
remoteName() took the first one, which could be a non-primary remote
(e.g. 'launchpad' before 'origin'). This caused deploy:push to update
GitHub variables on the wrong repository.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jonathonbyrdziak jonathonbyrdziak merged commit 4e994ac into master Mar 26, 2026
5 of 8 checks passed
@jonathonbyrdziak jonathonbyrdziak deleted the fix/git-remote-name-origin-preference branch March 26, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant