Skip to content

Add error logging to GitHub App token requests #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathonbyrdziak merged 1 commit into from
Mar 25, 2026
Merged

Add error logging to GitHub App token requests #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 38 additions & 5 deletions src/Helpers/GitHubApp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,31 @@ public static function generateJwt(string $appId, string $pemContents): ?string
public static function getInstallationId(string $jwt, string $owner): ?int
{
$result = Shell::run(
"curl -s -H " . escapeshellarg("Authorization: Bearer {$jwt}")
"curl -s -w '\\n%{http_code}' -H " . escapeshellarg("Authorization: Bearer {$jwt}")
. " -H 'Accept: application/vnd.github+json'"
. " https://api.github.com/app/installations 2>/dev/null"
);

if (!$result) {
Log::error('github-app', "installations list request returned empty response");
return null;
}

$installations = json_decode($result, true);
// Separate body from HTTP status code
$lines = explode("\n", trim($result));
$httpCode = (int) array_pop($lines);
$body = implode("\n", $lines);

if ($httpCode < 200 || $httpCode >= 300) {
$parsed = json_decode($body, true);
$message = $parsed['message'] ?? trim($body);
Log::error('github-app', "installations list failed: HTTP {$httpCode} — {$message}");
return null;
}

$installations = json_decode($body, true);
if (!is_array($installations)) {
Log::error('github-app', "installations response is not an array: " . trim($body));
return null;
}

Expand All @@ -133,6 +147,7 @@ public static function getInstallationId(string $jwt, string $owner): ?int
}
}

Log::warn('github-app', "no installation found for owner '{$owner}' among " . count($installations) . " installation(s)");
return null;
}

Expand All @@ -143,18 +158,36 @@ public static function getInstallationId(string $jwt, string $owner): ?int
public static function generateInstallationToken(string $jwt, int $installationId): ?string
{
$result = Shell::run(
"curl -s -X POST"
"curl -s -w '\\n%{http_code}' -X POST"
. " -H " . escapeshellarg("Authorization: Bearer {$jwt}")
. " -H 'Accept: application/vnd.github+json'"
. " https://api.github.com/app/installations/{$installationId}/access_tokens 2>/dev/null"
);

if (!$result) {
Log::error('github-app', "installation token request returned empty response for installation {$installationId}");
return null;
}

// Separate body from HTTP status code
$lines = explode("\n", trim($result));
$httpCode = (int) array_pop($lines);
$body = implode("\n", $lines);

$data = json_decode($body, true);

if ($httpCode < 200 || $httpCode >= 300) {
$message = $data['message'] ?? trim($body);
Log::error('github-app', "installation token request failed: HTTP {$httpCode} — {$message}");
return null;
}

if (!isset($data['token'])) {
Log::error('github-app', "installation token response missing 'token' field: " . trim($body));
return null;
}

$data = json_decode($result, true);
return $data['token'] ?? null;
return $data['token'];
}

/**
Expand Down
Loading