[pull] main from actions:main#259
Merged
Merged
Conversation
* Close Setup Assistant window in configure-windows.sh
The arm64 macOS 15 first-boot Setup Assistant can auto-launch after the
reboot triggered by the post-configure-machine provisioner. When that
happens, configure-windows.sh detects the open window and aborts the
Packer build.
Mirror the existing System Preferences quit pattern: try a graceful
AppleScript quit first, then fall back to a name-based process kill.
Both calls tolerate the app being absent, so the script remains a no-op
on healthy boots.
* Log Setup Assistant detection state in configure-windows.sh
Make the dismissal path observable. Previously the script unconditionally
printed "Close Setup Assistant window" and silently dropped the exit
codes of osascript/process kill, so we couldn't tell from logs whether
the window had actually been present or which fallback path resolved it.
Now the script emits one of three distinct messages per run:
- "Setup Assistant not running; no action needed"
- "Setup Assistant exited gracefully" (AppleScript quit succeeded)
- "Setup Assistant still running; force-killing" (kill fallback used)
This makes future regressions easier to triage by correlating run logs
to the actual behavior of the dismissal logic.
* Add pinnedDetails to cmake/llvm toolset entries to fix JSON schema validation
The validate-json-schema CI job was failing because 6 toolset files had
fully-pinned 3-segment versions (cmake 3.31.6 / llvm 20.1.6) but were
missing the required pinnedDetails object.
Add pinnedDetails (reason, link, review-at) to:
- images/ubuntu/toolsets/toolset-2204{,-arm64}.json (cmake 3.31.6)
- images/ubuntu/toolsets/toolset-2404{,-arm64}.json (cmake 3.31.6)
- images/windows/toolsets/toolset-win-11{,-vs2026}-arm64.json (llvm 20.1.6)
* fix docs
Co-authored-by: Nicholas Sakaimbo <nsakaimbo@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Update Rust installation script to pin rustup version Pin rustup installation to a specific commit and update the installation method. * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )