This repository was archived by the owner on Jun 12, 2025. It is now read-only.
Fix: Pair to data_feed; changing impact config #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 22, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good to me and tested simulation execution with different configs.
Just one question, do you think pair.py should live in /types/? Wondering as it's quite a class now with functionality, not just specifying types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
ReflectiveSerializableEnum, an extension ofSerializableEnumthat adds__contains__()method for valuesimpacted assets: allCELO/Fiatpairs are included andBTC/Fiat,ETH/Fiatare excluded as Celo network impact is currently unlikely