fix: support @Module.Const syntax in expressions#179
Open
engalar wants to merge 2 commits intomendixlabs:mainfrom
Open
fix: support @Module.Const syntax in expressions#179engalar wants to merge 2 commits intomendixlabs:mainfrom
engalar wants to merge 2 commits intomendixlabs:mainfrom
Conversation
Parser now accepts @QualifiedName as a constant reference in any expression context (DECLARE, SET, CHANGE, etc.), matching the output of DESCRIBE MICROFLOW. This restores the round-trip guarantee: DESCRIBE output can be fed back into CREATE without modification.
…oString The Executor.expressionToString method in cmd_diff_mdl.go was missing cases for ConstantRefExpr and QualifiedNameExpr, causing mxcli diff to output Go struct formatting instead of valid MDL syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
Summary
@QualifiedNameas a validatomicExpressionin the MDL grammar for constant referencesConstantRefExprAST node type for clean representation@ Module.Constparse tree toConstantRefExprexpressionToString()outputs@Module.Constfor BSON serializationgetConstantValue('Module.Const')still worksRound-trip restored
Test plan
mxcli checkaccepts@Module.Constsyntaxmxcli checkstill acceptsgetConstantValue('Module.Const')syntax