fix: strip REST path slashes and validate microflow param entity refs#170
Merged
ako merged 1 commit intomendixlabs:mainfrom Apr 10, 2026
Merged
fix: strip REST path slashes and validate microflow param entity refs#170ako merged 1 commit intomendixlabs:mainfrom
ako merged 1 commit intomendixlabs:mainfrom
Conversation
engalar
force-pushed
the
fix/doctype-test-failures
branch
from
e35eea2 to
9c14ffc
Compare
Root causes of TestMxCheck_DoctypeScripts failures: 1. REST service operation paths with leading/trailing slashes were stored as-is in BSON (CE6550/CE6551). Now stripped at parse time in visitor_rest.go. 2. Microflow parameters with bare entity names like "Object" (missing module prefix) were not caught by mxcli check. Added MDL008 validation in both ValidateMicroflow (linter) and ValidateMicroflowBody (semantic validator). 3. Test data fixes: REST param case mismatch ($Id → $id), workflow params (Object → System.Workflow/System.WorkflowUserTask).
engalar
force-pushed
the
fix/doctype-test-failures
branch
from
9c14ffc to
e1d9fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Objectwithout module prefix)$Id→$id, workflow paramsObject→System.WorkflowRoot causes
visitor_rest.gostored paths as-isstrings.Trim(path, "/")at parse time$Idvs{id}$idValidateMicroflowandValidateMicroflowBodyTest plan
mxcli check workflow-microflow-actions.mdlnow catchesObject→ 3 MDL008 errorsmxcli checkgo test ./mdl/...passes with 0 failures