[WTF-2518]: Enforce widgetName constraint in bundler #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdwater
changed the title
weirdwater
force-pushed
the
feature/check-widgetname
branch
from
81a6448 to
b57e787
Compare
weirdwater
force-pushed
the
feature/check-widgetname
branch
from
dcad387 to
f77de32
Compare
weirdwater
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Widget names are only allowed to contain lower and uppercase letters. This is checked by the generator when the developer is prompted for a widget name. However, this validation is never done during bundling. Since Studio Pro assumes this, a widget which had its name changed after generation could cause the deployment of an app to fail.
Relevant changes
A check was added to the bundler when the widgetName is retrieved from the widget's package.json.
What should be covered while testing?