Skip to content

Update CMake requirements #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinbarry merged 5 commits into from
Aug 14, 2025
Merged

Update CMake requirements #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17c84d7
chore: Empty commit to check CI test runners
colinbarry Aug 13, 2025
c008d33
wip: Update cmake minimum required version to 3.5!
colinbarry Aug 13, 2025
0911af4
wip: Update to gflags that supports modern cmake
colinbarry Aug 13, 2025
004eba4
wip: Try new gflags path
colinbarry Aug 13, 2025
1c7cb87
doc: Add comment about source of gflag GIT_TAG
colinbarry Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.

cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.5)
project(mgconsole VERSION 1.4)
include(CTest)

Expand Down
11 changes: 6 additions & 5 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ endif()

# Handle platforms
if(MGCONSOLE_ON_WINDOWS)
set(GFLAGS_WIN_LIB_SUFFIX "_static")
set(CMAKE_CXX_STANDARD_LIBRARIES "-static-libgcc -static-libstdc++ -lws2_32 -lcrypt32")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-Bstatic,--whole-archive -lwinpthread -Wl,--no-whole-archive")
elseif(MGCONSOLE_ON_LINUX)
Expand All @@ -56,11 +55,13 @@ else()
set(MG_INSTALL_LIB_DIR "lib")
endif()

# Setup GFlags
# Setup GFlags. The GIT_TAG refers to this build:
# https://github.com/gflags/gflags/tree/70c01a642f08734b7bddc9687884844ca117e080,
# which is the earliest to support modern cmake.
ExternalProject_Add(gflags-proj
PREFIX gflags
GIT_REPOSITORY https://github.com/gflags/gflags.git
GIT_TAG v2.2.2
GIT_TAG 70c01a6
CMAKE_ARGS "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
"-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
Expand All @@ -69,8 +70,8 @@ ExternalProject_Add(gflags-proj
ExternalProject_Get_Property(gflags-proj install_dir)
set(GFLAGS_ROOT ${install_dir})
set(GFLAGS_INCLUDE_DIRS ${GFLAGS_ROOT}/include)
set(GFLAGS_LIBRARY_PATH ${GFLAGS_ROOT}/lib/libgflags${GFLAGS_WIN_LIB_SUFFIX}.a)
set(GFLAGS_DEBUG_LIBRARY_PATH ${GFLAGS_ROOT}/lib/libgflags${GFLAGS_WIN_LIB_SUFFIX}_debug.a)
set(GFLAGS_LIBRARY_PATH ${GFLAGS_ROOT}/lib/libgflags.a)
set(GFLAGS_DEBUG_LIBRARY_PATH ${GFLAGS_ROOT}/lib/libgflags_debug.a)
set(GFLAGS_LIBRARY gflags)

add_library(${GFLAGS_LIBRARY} STATIC IMPORTED)
Expand Down
Loading