Skip to content

Conversation

@noahp
Copy link
Contributor

@noahp noahp commented Jun 13, 2024

Install from npm, because it's simpler, so use lefthook as the
pre-commit runner (yarn install automatically installs the hooks,
which is somewhat nice too).

I removed the reference to the grammarly vscode extension, since it's
no longer available in the marketplace and the github repo is archived.

@noahp noahp requested review from gminn, sarfata and tyhoff and removed request for tyhoff June 13, 2024 13:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 13, 2024

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: a347d91
Status: ✅  Deploy successful!
Preview URL: https://2ae16d13.interrupt.pages.dev
Branch Preview URL: https://noahp-lefthook.interrupt.pages.dev

View logs

Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this! been wanting it for a while ❤️ Can't wait to open the massive formatting and typos fixing PR 💥

@noahp noahp marked this pull request as ready for review July 17, 2024 12:40
@noahp noahp requested a review from gminn July 17, 2024 12:41
Install from npm, because it's simpler, so use lefthook as the
pre-commit runner (`yarn install` automatically installs the hooks,
which is somewhat nice too).

I removed the reference to the `grammarly` vscode extension, since it's
no longer available in the marketplace and the github repo is archived.
Copilot AI review requested due to automatic review settings December 23, 2025 20:12
@gminn gminn requested a review from a team as a code owner December 23, 2025 20:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds linting infrastructure to the repository by introducing lefthook as a pre-commit hook runner, prettier for markdown formatting, and typos-rs for spell checking. The PR also removes the deprecated Grammarly VSCode extension configuration and updates documentation to reflect the new setup requirements.

Key Changes:

  • Adds lefthook, prettier, and typos-rs as npm dependencies with pre-commit hook configuration
  • Removes deprecated Grammarly VSCode extension settings and replaces with prettier configuration
  • Updates README with instructions for installing yarn dependencies and running linters

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
yarn.lock Adds lockfile with lefthook 1.6.16, prettier 3.3.2, and typos-rs-npm dependencies
package.json Defines npm scripts for linting and declares project dependencies
lefthook.yml Configures pre-commit hooks to run prettier and typos on staged markdown files
_typos.toml Provides configuration file for typos spell checker
.vscode/settings.json Removes Grammarly settings and configures prettier as the default markdown formatter
.gitignore Adds node_modules and Yarn 2 specific directories to ignore list
.gitattributes Adds git attributes configuration for binary lockfile handling
readme.md Updates documentation with yarn installation instructions and reformats text with line wrapping

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gminn
Copy link
Member

gminn commented Dec 23, 2025

Got this branch building again 💪 I also confirmed that the lefthook prettier and typos checks are working well locally!

The error from build logs was:

➤ YN0070: Migrating from Yarn 1; automatically enabling the compatibility node-modules linker 👍

Changes I made to fix it:

  • Use Yarn 3:
yarn set version 3.6.3
  • Add nodeLinker: node-modules to .yarnrc.yml to configure yarn 3.

  • Finally, reset env and regenerate yarn.lock:

rm -rf node_modules && rm yarn.lock
yarn install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants