Added ADR-005: Define log levels#2948
Conversation
📝 WalkthroughWalkthroughThis PR adds ADR-005 Log Levels, defining six logging levels (FATAL, ERROR, WARN, INFO, DEBUG, TRACE) with meanings and example use-cases. It also includes an explicit directive not to log 404 Not Found responses. ADR-004 Logging is updated to document that the system ships with INFO log level in development. ChangesLogging Standards
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ADRs.md`:
- Around line 55-56: The ADR currently bans logging 404s via the line "Do not
Log: - 404 Not Found"; update that rule to be scoped guidance instead: replace
the absolute prohibition with text that says 404s should not be logged at ERROR
level when they are expected, but may be recorded at INFO/DEBUG level, via
sampling/aggregation, or elevated for security-sensitive endpoints; reference
the existing phrase "Do not Log: - 404 Not Found" and modify it to clarify
acceptable logging levels, sampling, and exceptions for security or routing
regressions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 75df8eba-3743-418f-8147-02a2c4a87d40
📒 Files selected for processing (1)
docs/ADRs.md
|
This pull request needs "/ok-to-test" from an authorized committer. |
Summary by CodeRabbit