This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Open
Conversation
…ed / pasted now etc.
Owner
|
I just tested your changes and I didn't see any change in behavior |
Author
|
@melishev Have you tested diffferences between two version as i feel you did not: Try these steps
It doesn't let you in current version, please retest from this angle and you'll see what i mean. I have this running in strapi and it works better, its tricky to show difference but there is, it needs more edge case testing too see the issues though. Hope all is well 👍 |
Owner
|
@kgrosvenor Okay, but conflicts need to be resolved before I can merge. |
|
@kgrosvenor Did you fix all the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed issues with the
onChangeevent not always being updated towards strapi, now it does and allows empty blocks, pasting blocks from other windows, ctrl+a and backspace.My IDE was flagging up
valuetwice in the WYSIWYG properties so I have omitted the second declaration made