fix: undefined View propTypes issue

[capelski]

Platforms affected

Google Chrome on Windows

What does this PR do?

Fix propTypes issues on browsers

What testing has been done on this change?

Launched the app in the Expo Client

[justinkchen]

thanks for this! would be great to get this bumped and merged in! thanks!

[FINKITT-PTY-LTD]

Yeah agreed, the merge would make my day guys!

[jaredswenson]

This works well, can we get a merge please?

[JijoBose]

Thanks, @capelski,
waiting for this to be merged 🚀

[cyphire]

containerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes?.style ? View.propTypes.style : () => null

instead... Your's didnt work for me, but the ?. does....

[Chris-Imade]

these solutions are awesome I'll try it out right away

[cyphire]

Same as above:

        contentContainerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes?.style ? View.propTypes.style : () => null,

[cyphire]

Sorry - terrible at using this github stuff!!!

You change did not fix the problem, still got red errors in chrome.... The following (just in the Carousel.js) did fix it as a slight mod to yours:

containerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes?.style ? View.propTypes.style : () => null,
contentContainerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes?.style ? View.propTypes.style : () => null,

[capelski]

Hi @cyphire. Which device and browser are you testing it from? The fix was working fine on a Windows 10 Chrome browser. The only difference in your code is checking that View.propTypes contains a property named style. In fact, your code would be more readable if you'd replace the ternary operator with an or operator:

Suggested change

	contentContainerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes ? View.propTypes.style : () => null,
	contentContainerCustomStyle: ViewPropTypes ? ViewPropTypes.style : View.propTypes?.style || () => null,

But again, in which case do you get a View.propTypes without the style property?

[BlameFelix]

This works, however I think the underlying problem is this. After applying the fix from the linked comment web also works fine for me.

[capelski]

As mentioned in #779 (comment), React Native deprecated propTypes. I'm closing this PR since it's not aligned with the React Native evolution and I'm creating #836, which removes ViewPropTypes usage instead of mocking it

[udemezue01]

How do we solve this, I am getting errors too

[Chris-Imade]

why isn't this correction merge...when I run yarn add react-native-snap-carousel I still get the not updated files

[Chris-Imade]

these solutions are awesome I'll try it out right away

[steveberdy]

If you want this code in your project instead of the current, broken code, you can npm uninstall react-native-snap-carousel and then npm install git+https://github.com/capelski/react-native-snap-carousel or your own working fork. You don't have to wait for it to be in the official NPM registry.