Skip to content

Update Ruby versions in GitHub Actions workflow#699

Open
Nymuxyzo wants to merge 3 commits into
meilisearch:mainfrom
Nymuxyzo:patch-1
Open

Update Ruby versions in GitHub Actions workflow#699
Nymuxyzo wants to merge 3 commits into
meilisearch:mainfrom
Nymuxyzo:patch-1

Conversation

@Nymuxyzo
Copy link
Copy Markdown
Contributor

@Nymuxyzo Nymuxyzo commented May 30, 2026

Pull Request

What does this PR do?

  • Update Ruby versions in GitHub action workflow

PR checklist

Please check if your PR fulfills the following requirements:

  • Did you use any AI tool while implementing this PR (code, tests, docs, etc.)? If yes, disclose it in the PR description and describe what it was used for. AI usage is allowed when it is disclosed.
  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Changes

Updated the GitHub Actions test workflow to use newer Ruby versions and conditional dependency installation, and added a runtime gem dependency:

  • Integration test matrix: Updated Ruby versions from 3.1, 3.2, 3.3 to 3.3, 3.4, 4.0
  • Dependency installation: bundle install runs without --with test for Ruby 4.0; other Ruby versions run bundle install --with test
  • Coverage upload: Codecov upload runs only for Ruby 3.3
  • Linter check job: Updated Ruby setup from 3.0 to 3.3
  • Gemspec: Added logger as a runtime dependency in meilisearch.gemspec

Files Changed

  • .github/workflows/tests.yml (+8/-3)
  • meilisearch.gemspec (+1/-0)

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95d280bc-c72a-49a5-a6aa-c0ae0d9b02bb

📥 Commits

Reviewing files that changed from the base of the PR and between 34d03f7 and 6f74ad2.

📒 Files selected for processing (1)
  • meilisearch.gemspec

📝 Walkthrough

Walkthrough

This PR updates the GitHub Actions test workflow: the integration matrix now runs on Ruby 3.3, 3.4, and 4.0; the dependency installation step conditionally omits the test group for Ruby 4.0; the linter job's Ruby version is changed to 3.3; and the gemspec adds logger as a runtime dependency.

Changes

Ruby Version Maintenance

Layer / File(s) Summary
Test matrix and dependency install
.github/workflows/tests.yml
Integration test matrix updated to 3.3, 3.4, 4.0. bundle install runs without --with test for 4.0, and with --with test for other versions.
Linter job Ruby setup
.github/workflows/tests.yml
linter_check job's ruby-version changed from 3.0 to 3.3.
Gemspec runtime dependency
meilisearch.gemspec
Added runtime dependency: s.add_dependency 'logger'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through YAML lanes tonight,
Bumped Ruby rows to brighter light,
Bundler choices now skip the test,
A logger joins the gemspec nest,
CI sings softly through the night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Update Ruby versions in GitHub Actions workflow' accurately describes the primary change in the changeset—updating Ruby versions from 3.1/3.2/3.3 to 3.3/3.4/4.0 in the workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (857afce) to head (6f74ad2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          809       809           
=========================================
  Hits           809       809           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant