feat: Support ruby 3.4 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykitamura-mdsol
commented
Jan 15, 2025
| spec.require_paths = ['lib'] | ||
|
|
||
| spec.add_dependency 'addressable', '~> 2.0' | ||
| spec.add_dependency 'base64', '~> 0.2' |
Contributor
Author
There was a problem hiding this comment.
base64 is a bundled gem now
ejinotti-mdsol
approved these changes
Jan 15, 2025
Contributor
|
Looks like rubocop doesn't like something in some of the old code 😬 |
Contributor
Author
|
I know 😎 |
Contributor
|
@ykitamura-mdsol Merged #70 but it didn't seem to pick up the changes |
ykitamura-mdsol
force-pushed
the
feature/ruby_34
branch
from
63900fd to
97f0f32
Compare
Contributor
Author
|
Thanks!! Rebased and all green now |
ejennings-mdsol
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in the title
@ejinotti-mdsol @ejennings-mdsol
Checklist
masterbundle exec appraisal update)