Open
Conversation
Fixes 3 things: - Keepnote doesn't support HMTL entities, so after retrieving the output from the highlight function, we need to convert back the entities to plaintext. Without this, many characters were just ignored such as quotes - Keepnote doesn't support TABs or multiple spaces so we need to replace them with with non breaking spaces so that indentation works correctly - Auto focus on the language combo box every time we open the syntax highlighter
Added style dropdown option
fixed default
We cannot unescape everything or it will cause some problems for example for PHP or HTML. This way we can escape only the minimum necessary
|
Any progress on this? Can we help with anything? |
Author
|
It's working for me :) Using it everyday without issues. |
|
On Sat, Jul 01, 2017 at 10:36:26AM -0700, Tiago Sintra wrote:
It's working for me :) Using it everyday without issues.
Let me know if you find any.
Thanks for the quick response!
I couldn't get it to run properly on a Windows 7 machine at my first
attempt, but it is probably related to my limited knowledge on Windows,
in particular combined with a Python environment...
Will give it a shot on my Linux workstation this week.
|
Author
|
Yeah I tried to get it working on Windows but I've ran into some issues as well. Specifically, you will need to have Python with pygments module installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to the not-yet-approved but awesome syntax highlighter developed by @mehdidc. Credits of the development go to him.
However there were some issues with the implementation: