Skip to content

Make mantadory parameters #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cosmo0920 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make mantadory parameters #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/fluent/plugin/in_gcloud_pubsub.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ class GcloudPubSubInput < Input

config_param :tag, :string
config_param :project, :string, :default => nil
config_param :topic, :string, :default => nil
config_param :subscription, :string, :default => nil
config_param :topic, :string
config_param :subscription, :string
config_param :key, :string, :default => nil
config_param :pull_interval, :integer, :default => 5
config_param :max_messages, :integer, :default => 100
Expand All @@ -26,9 +26,6 @@ class GcloudPubSubInput < Input
def configure(conf)
super

raise Fluent::ConfigError, "'topic' must be specified." unless @topic
raise Fluent::ConfigError, "'subscription' must be specified." unless @subscription

configure_parser(conf)
end

Expand Down
4 changes: 1 addition & 3 deletions lib/fluent/plugin/out_gcloud_pubsub.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class GcloudPubSubOutput < BufferedOutput
config_set_default :buffer_queue_limit, 64

config_param :project, :string, :default => nil
config_param :topic, :string, :default => nil
config_param :topic, :string
config_param :key, :string, :default => nil
config_param :autocreate_topic, :bool, :default => false

Expand All @@ -27,8 +27,6 @@ class GcloudPubSubOutput < BufferedOutput

def configure(conf)
super

raise Fluent::ConfigError, "'topic' must be specified." unless @topic
end

def start
Expand Down