modernize #10
Open
modernize #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
For the moment, I think this is OK to keep the actual codebase, this is still valid Javascript and it does not change a lot. Maybe @mde has a different point of view. |
Owner
|
Thanks for this, but PRs like this are way more likely to be merged if they are written in the same style as the rest of the codebase. Also this PR actually removes existing semicolons from otherwise-unchanged code. Apologies for not having a lint file here, but I would think the existing coding style is pretty consistent and easy to follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have made a issue first... sry about that.
anyway i turned this into a class to better help with smarter typing support